Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[lldb/PlatformDarwin] Be more robust in computing the SDK path with x…
…crun The current implementation isn't very resilient when it comes to the output of xcrun. Currently it cannot deal with: - Trailing newlines. - Leading newlines and errors/warnings before the Xcode path. - Xcode not being named Xcode.app. This extract the logic into a helper in PlatformDarwin and fixes those issues. It's also the first step towards removing code duplication between the different platforms and downstream Swift. Differential revision: https://reviews.llvm.org/D76261 (cherry picked from commit 7aa2899)
- Loading branch information
1 parent
3138d90
commit c84bdb0
Showing
4 changed files
with
266 additions
and
161 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.