Revert "[flang] OpenMP allocate directive parse tree fix"

This reverts commit eaf7d97.
Arcanist stripped co-author data from initial commit.

flang/lib/Parser/unparse.cpp

@@ -2325,14 +2325,6 @@ class UnparseVisitor {
     EndOpenMP();
   }
   void Unparse(const OpenMPExecutableAllocate &x) {
-    const auto &fields =
-        std::get<std::optional<std::list<parser::OpenMPDeclarativeAllocate>>>(
-            x.t);
-    if (fields) {
-      for (const auto &decl : *fields) {
-        Walk(decl);
-      }
-    }
     BeginOpenMP();
     Word("!$OMP ALLOCATE");
     Walk(" (", std::get<std::optional<OmpObjectList>>(x.t), ")");

flang/lib/Semantics/canonicalize-omp.cpp

@@ -15,9 +15,7 @@
 //   1. move structured DoConstruct and OmpEndLoopDirective into
 //      OpenMPLoopConstruct. Compilation will not proceed in case of errors
 //      after this pass.
-//   2. Associate declarative OMP allocation directives with their
-//      respective executable allocation directive
-//   3. TBD
+//   2. TBD
 namespace Fortran::semantics {
 
 using namespace parser::literals;
@@ -48,8 +46,6 @@ class CanonicalizationOfOmp {
     } // Block list
   }
 
-  void Post(parser::ExecutionPart &body) { RewriteOmpAllocations(body); }
-
 private:
   template <typename T> T *GetConstructIf(parser::ExecutionPartConstruct &x) {
     if (auto *y{std::get_if<parser::ExecutableConstruct>(&x.u)}) {
@@ -60,15 +56,6 @@ class CanonicalizationOfOmp {
     return nullptr;
   }
 
-  template <typename T> T *GetOmpIf(parser::ExecutionPartConstruct &x) {
-    if (auto *construct{GetConstructIf<parser::OpenMPConstruct>(x)}) {
-      if (auto *omp{std::get_if<T>(&construct->u)}) {
-        return omp;
-      }
-    }
-    return nullptr;
-  }
-
   void RewriteOpenMPLoopConstruct(parser::OpenMPLoopConstruct &x,
       parser::Block &block, parser::Block::iterator it) {
     // Check the sequence of DoConstruct and OmpEndLoopDirective
@@ -119,36 +106,6 @@ class CanonicalizationOfOmp {
         parser::ToUpperCaseLetters(dir.source.ToString()));
   }
 
-  void RewriteOmpAllocations(parser::ExecutionPart &body) {
-    // Rewrite leading declarative allocations so they are nested
-    // within their respective executable allocate directive
-    //
-    // Original:
-    //   ExecutionPartConstruct -> OpenMPDeclarativeAllocate
-    //   ExecutionPartConstruct -> OpenMPDeclarativeAllocate
-    //   ExecutionPartConstruct -> OpenMPExecutableAllocate
-    //
-    // After rewriting:
-    //   ExecutionPartConstruct -> OpenMPExecutableAllocate
-    //     ExecutionPartConstruct -> OpenMPDeclarativeAllocate
-    //     ExecutionPartConstruct -> OpenMPDeclarativeAllocate
-    for (auto it = body.v.rbegin(); it != body.v.rend();) {
-      if (auto *exec = GetOmpIf<parser::OpenMPExecutableAllocate>(*(it++))) {
-        parser::OpenMPDeclarativeAllocate *decl;
-        std::list<parser::OpenMPDeclarativeAllocate> subAllocates;
-        while (it != body.v.rend() &&
-            (decl = GetOmpIf<parser::OpenMPDeclarativeAllocate>(*it))) {
-          subAllocates.push_front(std::move(*decl));
-          it = decltype(it)(body.v.erase(std::next(it).base()));
-        }
-        if (!subAllocates.empty()) {
-          std::get<std::optional<std::list<parser::OpenMPDeclarativeAllocate>>>(
-              exec->t) = {std::move(subAllocates)};
-        }
-      }
-    }
-  }
-
   parser::Messages &messages_;
 };
 

flang/lib/Semantics/resolve-directives.cpp

@@ -1691,8 +1691,7 @@ void OmpAttributeVisitor::ResolveOmpObject(
                   }
                 }
                 if (ompFlag == Symbol::Flag::OmpDeclarativeAllocateDirective &&
-                    IsAllocatable(*symbol) &&
-                    !IsNestedInDirective(llvm::omp::Directive::OMPD_allocate)) {
+                    IsAllocatable(*symbol)) {
                   context_.Say(designator.source,
                       "List items specified in the ALLOCATE directive must not "
                       "have the ALLOCATABLE attribute unless the directive is "