Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[MC] Make .pseudo_probe sections deterministic after D91878
MCPseudoProbeSections::emit iterates over MCProbeDivisions and creates sections. When the map key is MCSymbol *, the iteration order is not stable. The underlying BumpPtrAllocator largely decreases the flakiness. That said, the allocations from BumpPtrAllocator may have different orders. Under tcmalloc, llvm/test/Transforms/SampleProfile/pseudo-probe-emit.ll fails about 7 times per 1000 runs.
- Loading branch information
c8fd0cf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be breaking ASAN buildbots:
https://lab.llvm.org/buildbot/#/builders/168/builds/15785
https://lab.llvm.org/buildbot/#/builders/5/builds/36824