Skip to content

Commit

Permalink
Provide storage for true_type::value and false_type::value.
Browse files Browse the repository at this point in the history
Summary:
This fixes linker errors that occurs when the
`sanitizer_type_traits_test.cc` is built without optimizations.

The error occurs because the test tries to take a reference.
A possible workaround is to give the GTest macros take boolean rvalues
by doing something like:

```
ASSERT_TRUE(bool(is_same<uptr, uptr>::value));
```

However this only hides the problem. Unfortunately Using `constexpr`
won't fix the problem unless we are using C++17.

Reviewers: vitalybuka, kubamracek, george.karpenkov, yln

Subscribers: mgorny, #sanitizers, llvm-commits

Differential Revision: https://reviews.llvm.org/D56035

llvm-svn: 350940
  • Loading branch information
delcypher committed Jan 11, 2019
1 parent ee10ef7 commit cb09a6f
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 0 deletions.
1 change: 1 addition & 0 deletions compiler-rt/lib/sanitizer_common/CMakeLists.txt
Expand Up @@ -38,6 +38,7 @@ set(SANITIZER_SOURCES_NOTERMINATION
sanitizer_suppressions.cc
sanitizer_tls_get_addr.cc
sanitizer_thread_registry.cc
sanitizer_type_traits.cc
sanitizer_win.cc)

if(UNIX AND NOT APPLE AND NOT OS_NAME MATCHES "SunOS")
Expand Down
21 changes: 21 additions & 0 deletions compiler-rt/lib/sanitizer_common/sanitizer_type_traits.cc
@@ -0,0 +1,21 @@
//===-- sanitizer_type_traits.cc --------------------------------*- C++ -*-===//
//
// The LLVM Compiler Infrastructure
//
// This file is distributed under the University of Illinois Open Source
// License. See LICENSE.TXT for details.
//
//===----------------------------------------------------------------------===//
//
// Implements a subset of C++ type traits. This is so we can avoid depending
// on system C++ headers.
//
//===----------------------------------------------------------------------===//
#include "sanitizer_type_traits.h"

namespace __sanitizer {

const bool true_type::value;
const bool false_type::value;

} // namespace __sanitizer

0 comments on commit cb09a6f

Please sign in to comment.