Skip to content

Commit

Permalink
[OpenMP] [amdgpu] Added a synchronous version of data exchange. (#87032)
Browse files Browse the repository at this point in the history
Similar to H2D and D2H, use synchronous mode for large data transfers
beyond a certain size for D2D as well. As with H2D and D2H, this size is
controlled by an env-var.
  • Loading branch information
dhruvachak committed Mar 29, 2024
1 parent 3a106e5 commit cc8c6b0
Show file tree
Hide file tree
Showing 2 changed files with 93 additions and 0 deletions.
21 changes: 21 additions & 0 deletions openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2402,6 +2402,27 @@ struct AMDGPUDeviceTy : public GenericDeviceTy, AMDGenericDeviceTy {
AsyncInfoWrapperTy &AsyncInfoWrapper) override {
AMDGPUDeviceTy &DstDevice = static_cast<AMDGPUDeviceTy &>(DstGenericDevice);

// For large transfers use synchronous behavior.
if (Size >= OMPX_MaxAsyncCopyBytes) {
if (AsyncInfoWrapper.hasQueue())
if (auto Err = synchronize(AsyncInfoWrapper))
return Err;

AMDGPUSignalTy Signal;
if (auto Err = Signal.init())
return Err;

if (auto Err = utils::asyncMemCopy(
useMultipleSdmaEngines(), DstPtr, DstDevice.getAgent(), SrcPtr,
getAgent(), (uint64_t)Size, 0, nullptr, Signal.get()))
return Err;

if (auto Err = Signal.wait(getStreamBusyWaitMicroseconds()))
return Err;

return Signal.deinit();
}

AMDGPUStreamTy *Stream = nullptr;
if (auto Err = getStream(AsyncInfoWrapper, Stream))
return Err;
Expand Down
72 changes: 72 additions & 0 deletions openmp/libomptarget/test/offloading/d2d_memcpy_sync.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
// RUN: %libomptarget-compile-generic && \
// RUN: env LIBOMPTARGET_AMDGPU_MAX_ASYNC_COPY_BYTES=0 %libomptarget-run-generic | \
// RUN: %fcheck-generic -allow-empty
// REQUIRES: amdgcn-amd-amdhsa

#include <assert.h>
#include <omp.h>
#include <stdio.h>
#include <stdlib.h>

const int magic_num = 7;

int main(int argc, char *argv[]) {
const int N = 128;
const int num_devices = omp_get_num_devices();

// No target device, just return
if (num_devices == 0) {
printf("PASS\n");
return 0;
}

const int src_device = 0;
int dst_device = num_devices - 1;

int length = N * sizeof(int);
int *src_ptr = omp_target_alloc(length, src_device);
int *dst_ptr = omp_target_alloc(length, dst_device);

if (!src_ptr || !dst_ptr) {
printf("FAIL\n");
return 1;
}

#pragma omp target teams distribute parallel for device(src_device) \
is_device_ptr(src_ptr)
for (int i = 0; i < N; ++i) {
src_ptr[i] = magic_num;
}

if (omp_target_memcpy(dst_ptr, src_ptr, length, 0, 0, dst_device,
src_device)) {
printf("FAIL\n");
return 1;
}

int *buffer = malloc(length);
if (!buffer) {
printf("FAIL\n");
return 1;
}

#pragma omp target teams distribute parallel for device(dst_device) \
map(from : buffer[0 : N]) is_device_ptr(dst_ptr)
for (int i = 0; i < N; ++i) {
buffer[i] = dst_ptr[i] + magic_num;
}

for (int i = 0; i < N; ++i)
assert(buffer[i] == 2 * magic_num);

printf("PASS\n");

// Free host and device memory
free(buffer);
omp_target_free(src_ptr, src_device);
omp_target_free(dst_ptr, dst_device);

return 0;
}

// CHECK: PASS

0 comments on commit cc8c6b0

Please sign in to comment.