Skip to content

Commit

Permalink
Revert "[compiler-rt] Improve defaults for Android"
Browse files Browse the repository at this point in the history
This reverts commit cf403c1.

This is breaking Android sanitizer buildbots (see the discussion on
https://reviews.llvm.org/D158793).
  • Loading branch information
smeenai committed Aug 29, 2023
1 parent 27549ee commit cd8bba9
Showing 1 changed file with 4 additions and 10 deletions.
14 changes: 4 additions & 10 deletions compiler-rt/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ macro(handle_default_cxx_lib var)
if (APPLE OR CMAKE_SYSTEM_NAME MATCHES "FreeBSD")
set(${var}_LIBNAME "libc++")
set(${var}_SYSTEM 1)
elseif (ANDROID OR FUCHSIA)
elseif (FUCHSIA)
set(${var}_LIBNAME "libc++")
set(${var}_INTREE 1)
else()
Expand Down Expand Up @@ -227,19 +227,13 @@ set(CXXLIBS none default libstdc++ libc++)
set_property(CACHE SANITIZER_TEST_CXX PROPERTY STRINGS ;${CXXLIBS})
handle_default_cxx_lib(SANITIZER_TEST_CXX)

set(DEFAULT_COMPILER_RT_USE_LLVM_UNWINDER OFF)
if (ANDROID)
set(DEFAULT_COMPILER_RT_USE_LLVM_UNWINDER ON)
endif()

option(COMPILER_RT_USE_LLVM_UNWINDER
"Use the LLVM unwinder." ${DEFAULT_COMPILER_RT_USE_LLVM_UNWINDER})
option(COMPILER_RT_USE_LLVM_UNWINDER "Use the LLVM unwinder." OFF)
cmake_dependent_option(COMPILER_RT_ENABLE_STATIC_UNWINDER
"Statically link the LLVM unwinder." OFF
"COMPILER_RT_USE_LLVM_UNWINDER" OFF)

set(DEFAULT_SANITIZER_USE_STATIC_LLVM_UNWINDER OFF)
if (ANDROID OR FUCHSIA)
if (FUCHSIA)
set(DEFAULT_SANITIZER_USE_STATIC_LLVM_UNWINDER ON)
elseif (DEFINED LIBUNWIND_ENABLE_SHARED AND NOT LIBUNWIND_ENABLE_SHARED)
set(DEFAULT_SANITIZER_USE_STATIC_LLVM_UNWINDER ON)
Expand Down Expand Up @@ -277,7 +271,7 @@ cmake_dependent_option(COMPILER_RT_STATIC_CXX_LIBRARY
"COMPILER_RT_CXX_LIBRARY" OFF)

set(DEFAULT_COMPILER_RT_USE_BUILTINS_LIBRARY OFF)
if (ANDROID OR FUCHSIA)
if (FUCHSIA)
set(DEFAULT_COMPILER_RT_USE_BUILTINS_LIBRARY ON)
endif()

Expand Down

0 comments on commit cd8bba9

Please sign in to comment.