Don't create dynamic relocations for weak undefined symbols.

llvm-svn: 249520
llvm · Oct 7, 2015 · cea0b3b · cea0b3b
1 parent 55bbe66
commit cea0b3b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lld/ELF/OutputSections.cpp b/lld/ELF/OutputSections.cpp
@@ -413,7 +413,9 @@ lld::elf2::getLocalSymVA(const typename ELFFile<ELFT>::Elf_Sym *Sym,
 bool lld::elf2::canBePreempted(const SymbolBody *Body) {
   if (!Body)
     return false;
-  if (Body->isShared() || Body->isUndefined())
+  if (Body->isShared())
+    return true;
+  if (Body->isUndefined() && !Body->isWeak())
     return true;
   if (!Config->Shared)
     return false;

diff --git a/lld/test/elf2/dynamic-reloc.s b/lld/test/elf2/dynamic-reloc.s
@@ -59,4 +59,6 @@
 .global _start
 _start:
 .quad bar + 0x42
+.weak foo
+.quad foo
 call main