Skip to content

Commit

Permalink
[MLIR] Fix unused tablegen template arg warnings
Browse files Browse the repository at this point in the history
Identified in D109359.

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D110805
  • Loading branch information
c-rhodes committed Oct 4, 2021
1 parent 39f3f7c commit d023298
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion mlir/include/mlir/Dialect/Tosa/IR/TosaTypesBase.td
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ class Tosa_TypeLike<list<Type> types, string description = ""> : TypeConstraint<
AnyTypeOf<types>.predicate,
VectorOf<types>.predicate,
TensorOf<types>.predicate]>,
"signless-integer-32-like">;
description>;

def Tosa_Int8Like : Tosa_TypeLike<[Tosa_Int8], "signless-integer-8-bit-like">;
def Tosa_Int16Like : Tosa_TypeLike<[Tosa_Int16], "signless-integer-16-bit-like">;
Expand Down
9 changes: 4 additions & 5 deletions mlir/include/mlir/IR/OpBase.td
Original file line number Diff line number Diff line change
Expand Up @@ -2083,16 +2083,15 @@ class TypeInterface<string name> : Interface<name>, InterfaceTrait<name>;
// declarations should be generated. This class takes an optional set of methods
// that should have declarations generated even if the method has a default
// implementation.
class DeclareInterfaceMethods<Interface interface,
list<string> overridenMethods = []> {
class DeclareInterfaceMethods<list<string> overridenMethods = []> {
// This field contains a set of method names that should always have their
// declarations generated. This allows for generating declarations for
// methods with default implementations that need to be overridden.
list<string> alwaysOverriddenMethods = overridenMethods;
}
class DeclareAttrInterfaceMethods<AttrInterface interface,
list<string> overridenMethods = []>
: DeclareInterfaceMethods<interface, overridenMethods>,
: DeclareInterfaceMethods<overridenMethods>,
AttrInterface<interface.cppClassName> {
let description = interface.description;
let cppClassName = interface.cppClassName;
Expand All @@ -2101,7 +2100,7 @@ class DeclareAttrInterfaceMethods<AttrInterface interface,
}
class DeclareOpInterfaceMethods<OpInterface interface,
list<string> overridenMethods = []>
: DeclareInterfaceMethods<interface, overridenMethods>,
: DeclareInterfaceMethods<overridenMethods>,
OpInterface<interface.cppClassName> {
let description = interface.description;
let cppClassName = interface.cppClassName;
Expand All @@ -2110,7 +2109,7 @@ class DeclareOpInterfaceMethods<OpInterface interface,
}
class DeclareTypeInterfaceMethods<TypeInterface interface,
list<string> overridenMethods = []>
: DeclareInterfaceMethods<interface, overridenMethods>,
: DeclareInterfaceMethods<overridenMethods>,
TypeInterface<interface.cppClassName> {
let description = interface.description;
let cppClassName = interface.cppClassName;
Expand Down

0 comments on commit d023298

Please sign in to comment.