Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
------------------------------------------------------------------------ r367134 | nathan-huckleberry | 2019-07-26 19:29:35 +0200 (Fri, 26 Jul 2019) | 16 lines [Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression Summary: Do not automatically report self references of structs in statement expression as warnings. Instead wait for uninitialized cfg analysis. https://bugs.llvm.org/show_bug.cgi?id=42604 Reviewers: aaron.ballman, rsmith, nickdesaulniers Reviewed By: aaron.ballman, nickdesaulniers Subscribers: nathanchance, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D64678 ------------------------------------------------------------------------ llvm-svn: 367150
- Loading branch information
Showing
2 changed files
with
62 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
// RUN: %clang_cc1 -fsyntax-only -Wuninitialized -verify %s | ||
|
||
void init(int *); | ||
|
||
void foo(void) { | ||
int i = ({ | ||
init(&i); | ||
i; | ||
}); | ||
} | ||
|
||
void foo_bad(void) { | ||
int i = ({ | ||
int z = i; // expected-warning{{variable 'i' is uninitialized when used within its own initialization}} | ||
init(&i); | ||
i; | ||
}); | ||
} | ||
|
||
struct widget { | ||
int x, y; | ||
}; | ||
void init2(struct widget *); | ||
|
||
void bar(void) { | ||
struct widget my_widget = ({ | ||
init2(&my_widget); | ||
my_widget; | ||
}); | ||
struct widget a = (init2(&a), a); | ||
} | ||
|
||
void bar_bad(void) { | ||
struct widget my_widget = ({ | ||
struct widget z = my_widget; // expected-warning{{variable 'my_widget' is uninitialized when used within its own initialization}} | ||
int x = my_widget.x; //FIXME: There should be an uninitialized warning here | ||
init2(&my_widget); | ||
my_widget; | ||
}); | ||
} | ||
|
||
void baz(void) { | ||
struct widget a = ({ | ||
struct widget b = ({ | ||
b = a; // expected-warning{{variable 'a' is uninitialized when used within its own initialization}} | ||
}); | ||
a; | ||
}); | ||
} | ||
|
||
void f(void) { | ||
struct widget *a = ({ | ||
init2(a); // expected-warning{{variable 'a' is uninitialized when used within its own initialization}} | ||
a; | ||
}); | ||
} |