Skip to content

Commit

Permalink
Add mention to avoid cl::opt for MLIR passes in the developer guide
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 281338448
  • Loading branch information
joker-eph authored and tensorflower-gardener committed Nov 19, 2019
1 parent dd5a7cb commit d324c61
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions mlir/g3doc/DeveloperGuide.md
Expand Up @@ -38,6 +38,12 @@ with the pass name. For example, the affine dialect provides a loop tiling pass
that is registered on the command line as `-affine-tile`, and with a tile size
option that can be set with `-affine-tile-size`.

We also avoid `cl::opt` to provide pass options in favor of the
[pass options](WritingAPass.md#instance-specific-pass-options) mechanism. This
allows for these options to be serialized in a pass pipeline description, as
well as passing different options to multiple instances of a pass in the same
pipeline.

## Testing guidelines

See here for the [testing guide](TestingGuide.md).

0 comments on commit d324c61

Please sign in to comment.