Skip to content

Commit

Permalink
[CUDA] Don't assume that destructors can't be overloaded.
Browse files Browse the repository at this point in the history
Summary:
You can overload a destructor in CUDA, and SemaOverload needs to be
tweaked not to crash when it sees an explicit call to an overloaded
destructor.

Reviewers: rsmith

Subscribers: cfe-commits, tra

Differential Revision: http://reviews.llvm.org/D21912

llvm-svn: 275231
  • Loading branch information
Justin Lebar committed Jul 12, 2016
1 parent 51078b8 commit d35f706
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 2 deletions.
3 changes: 1 addition & 2 deletions clang/lib/Sema/SemaOverload.cpp
Expand Up @@ -12407,8 +12407,7 @@ Sema::BuildCallToMemberFunction(Scope *S, Expr *MemExprE,
if (CXXDestructorDecl *DD =
dyn_cast<CXXDestructorDecl>(TheCall->getMethodDecl())) {
// a->A::f() doesn't go through the vtable, except in AppleKext mode.
bool CallCanBeVirtual = !cast<MemberExpr>(NakedMemExpr)->hasQualifier() ||
getLangOpts().AppleKext;
bool CallCanBeVirtual = !MemExpr->hasQualifier() || getLangOpts().AppleKext;
CheckVirtualDtorCall(DD, MemExpr->getLocStart(), /*IsDelete=*/false,
CallCanBeVirtual, /*WarnOnNonAbstractTypes=*/true,
MemExpr->getMemberLoc());
Expand Down
17 changes: 17 additions & 0 deletions clang/test/SemaCUDA/call-overloaded-destructor.cu
@@ -0,0 +1,17 @@
// expected-no-diagnostics

// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fsyntax-only -verify %s
// RUN: %clang_cc1 -triple nvptx64-nvidia-cuda -fsyntax-only -fcuda-is-device -verify %s

#include "Inputs/cuda.h"

struct S {
__host__ ~S() {}
__device__ ~S() {}
};

__host__ __device__ void test() {
S s;
// This should not crash clang.
s.~S();
}

0 comments on commit d35f706

Please sign in to comment.