Skip to content

Commit

Permalink
[dotest] Remove multiprocessing
Browse files Browse the repository at this point in the history
Now that the Xcode project is removed, I want to focus on dotest as a
test framework, and remove its driver capabilities for which we already
rely on llvm's lit. Removing multiprocessing is the first step in that
direction.

Differential revision: https://reviews.llvm.org/D65311

llvm-svn: 367331
  • Loading branch information
JDevlieghere committed Jul 30, 2019
1 parent 8990516 commit d3ae0bc
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 1,913 deletions.
20 changes: 1 addition & 19 deletions lldb/docs/resources/test.rst
Expand Up @@ -88,22 +88,6 @@ Many more options that are available. To see a list of all of them, run:

> python dotest.py -h

The ``dotest.py`` script runs tests in parallel by default. To disable the
parallel test running feature, use the ``--no-multiprocess`` flag. The number
of concurrent tests is controlled by the ``LLDB_TEST_THREADS`` environment
variable or the ``--threads command`` line parameter. The default value is the
number of CPU cores on your system.

The parallel test running feature will handle an additional ``--test-subdir
SUBDIR`` arg. When specified, ``SUBDIR`` is relative to the root test directory
and will limit all parallel test running to that subdirectory's tree of tests.

The parallel test runner will run all tests within a given directory serially,
but will run multiple directories concurrently. Thus, as a test writer, we
provide serialized test run semantics within a directory. Note child
directories are considered entirely separate, so two child directories could be
running in parallel with a parent directory.

Running the Test Suite Remotely
-------------------------------

Expand Down Expand Up @@ -157,7 +141,7 @@ A quick guide to getting started with PTVS is as follows:
#. If you want to enabled mixed mode debugging, check Enable native code debugging (this slows down debugging, so enable it only on an as-needed basis.)
#. Set the command line for the test suite to run.
#. Right click the project in solution explorer and choose the Debug tab.
#. Enter the arguments to dotest.py. Note you must add --no-multiprocess
#. Enter the arguments to dotest.py.
#. Example command options:

::
Expand All @@ -178,8 +162,6 @@ A quick guide to getting started with PTVS is as follows:
-p TestPaths.py
# Root of test tree
D:\src\llvm\tools\lldb\packages\Python\lldbsuite\test
# Required in order to be able to debug the test.
--no-multiprocess

::

Expand Down
6 changes: 0 additions & 6 deletions lldb/packages/Python/lldbsuite/test/configuration.py
Expand Up @@ -117,12 +117,6 @@
# takes precedence.
exclusive_test_subdir = None

# Parallel execution settings
is_inferior_test_runner = False
num_threads = None
no_multiprocess_test_runner = False
test_runner_name = None

# Test results handling globals
results_filename = None
results_port = None
Expand Down

0 comments on commit d3ae0bc

Please sign in to comment.