Skip to content

Commit

Permalink
Revert "[RISCV] Enable strict assertions in InsertVSETVLI data flow"
Browse files Browse the repository at this point in the history
This reverts commit 79a66ec.

The stronger asserts served their purpose; I stumbled across another bug.  Will reapply once this one is also fixed.

The bug appears to be a variant of a previous one:
* We mutate an instruction in one block.
* That mutation changes the phase3 results of another block.

This is very similiar to a previous issue, except cross block instead of within a single block.
  • Loading branch information
preames committed May 17, 2022
1 parent 996834e commit d4545e6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp
Expand Up @@ -38,7 +38,7 @@ static cl::opt<bool> DisableInsertVSETVLPHIOpt(
cl::desc("Disable looking through phis when inserting vsetvlis."));

static cl::opt<bool> UseStrictAsserts(
"riscv-insert-vsetvl-strict-asserts", cl::init(true), cl::Hidden,
"riscv-insert-vsetvl-strict-asserts", cl::init(false), cl::Hidden,
cl::desc("Enable strict assertion checking for the dataflow algorithm"));

namespace {
Expand Down

0 comments on commit d4545e6

Please sign in to comment.