Skip to content

Commit

Permalink
Disable symbol on-demand feature for Windows
Browse files Browse the repository at this point in the history
Symbol on-demand feature is never tested on Windows so it is not a surprise
that we are getting Buildbot failure from Windows:
https://lab.llvm.org/buildbot/#/builders/83/builds/18228

This patch disables symbol on-demand feature on Windows. I will find a Windows
machine to test and re-enable symbol on-demand feature as follow-up.

Differential Revision: https://reviews.llvm.org/D124471
  • Loading branch information
Jeffrey Tan committed Apr 26, 2022
1 parent aabeb5e commit d738d47
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 0 deletions.
Expand Up @@ -20,6 +20,7 @@ def check_location_file(self, bp, loc, test_name):
comp_name = comp_unit.GetFileSpec().GetFilename()
return comp_name == test_name

@skipIfWindows
def test_regex_breakpoint_language(self):
"""Test that the name regex breakpoint commands obey the language filter."""

Expand Down Expand Up @@ -65,6 +66,7 @@ def test_regex_breakpoint_language(self):
objc_bp.GetNumLocations(), 0,
"No ObjC symbol matches")

@skipIfWindows
def test_by_name_breakpoint_language(self):
"""Test that the name regex breakpoint commands obey the language filter."""

Expand Down
Expand Up @@ -13,6 +13,7 @@
class TestSourceTextRegexBreakpoint(TestBase):
mydir = TestBase.compute_mydir(__file__)

@skipIfWindows
def test_with_run_command(self):
self.build()

Expand Down
3 changes: 3 additions & 0 deletions lldb/test/API/symbol_ondemand/shared_library/TestSharedLib.py
Expand Up @@ -38,6 +38,7 @@ def common_setup(self):
ctx = self.platformContext
self.shared_lib_name = ctx.shlib_prefix + "foo." + ctx.shlib_extension

@skipIfWindows
def test_source_line_breakpoint(self):
self.build()
self.common_setup()
Expand Down Expand Up @@ -75,6 +76,7 @@ def test_source_line_breakpoint(self):
)
self.assertEqual(7, parent_frame.GetLineEntry().GetLine())

@skipIfWindows
def test_symbolic_breakpoint(self):
self.build()
self.common_setup()
Expand Down Expand Up @@ -112,6 +114,7 @@ def test_symbolic_breakpoint(self):
)
self.assertEqual(7, parent_frame.GetLineEntry().GetLine())

@skipIfWindows
def test_global_variable_hydration(self):
self.build()
self.common_setup()
Expand Down
1 change: 1 addition & 0 deletions lldb/test/Shell/SymbolFile/OnDemand/source-breakpoint.test
@@ -1,5 +1,6 @@
# Test shows that source line breakpoint works with LLDB on demand symbol loading.

# UNSUPPORTED: system-windows
# RUN: mkdir -p %t
# RUN: cd %t
# RUN: %build %p/Inputs/basic.cpp -o basic.out
Expand Down
@@ -1,5 +1,6 @@
# Test shows that symbolic function breakpoint works with LLDB on demand symbol loading.

# UNSUPPORTED: system-windows
# RUN: mkdir -p %t
# RUN: cd %t
# RUN: %build %p/Inputs/basic.cpp -o basic.out
Expand Down

0 comments on commit d738d47

Please sign in to comment.