Skip to content

Commit

Permalink
[TestGdbRemoteRegisterState] Do not flip ARM *psr register in the test
Browse files Browse the repository at this point in the history
Summary:
Not all of that register is readable/writable in user mode. This means
that even if the inferior is stopped, parts of the register could be
changing. So, do not flip this register to check if its value can be
restored.

Reviewers: tberghammer, chaoren

Reviewed By: tberghammer

Subscribers: rengolin, aemerson, lldb-commits

Differential Revision: http://reviews.llvm.org/D10204

llvm-svn: 239104
  • Loading branch information
Siva Chandra committed Jun 4, 2015
1 parent 348efdb commit d772ef3
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions lldb/test/tools/lldb-server/gdbremote_testcase.py
Original file line number Diff line number Diff line change
Expand Up @@ -1065,6 +1065,9 @@ def is_bit_flippable_register(self, reg_info):
# This is a 2-letter register name that ends in "s", like a segment register.
# Don't try to bit flip these.
return False
if re.match("^(c|)psr$", reg_info["name"]):
# This is an ARM program status register; don't flip it.
return False
# Okay, this looks fine-enough.
return True

Expand Down

0 comments on commit d772ef3

Please sign in to comment.