-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[-Wunsafe-buffer-usage] Handle pointer initializations for grouping r…
…elated variables Differential Revision: https://reviews.llvm.org/D150489
- Loading branch information
Showing
7 changed files
with
252 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89 changes: 89 additions & 0 deletions
89
clang/test/SemaCXX/warn-unsafe-buffer-usage-multi-decl-ptr-init-fixits.cpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| // RUN: %clang_cc1 -std=c++20 -Wunsafe-buffer-usage \ | ||
| // RUN: -fsafe-buffer-usage-suggestions \ | ||
| // RUN: -fdiagnostics-parseable-fixits %s 2>&1 | FileCheck %s | ||
|
|
||
| void lhs_span_multi_assign() { | ||
| int *a = new int[2]; | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-1]]:3-[[@LINE-1]]:11}:"std::span<int> a" | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-2]]:12-[[@LINE-2]]:12}:"{" | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-3]]:22-[[@LINE-3]]:22}:", 2}" | ||
| int *b = a; | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-1]]:3-[[@LINE-1]]:11}:"std::span<int> b" | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-2]]:12-[[@LINE-2]]:12}:"{" | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-3]]:13-[[@LINE-3]]:13}:", <# placeholder #>}" | ||
| int *c = b; | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-1]]:3-[[@LINE-1]]:11}:"std::span<int> c" | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-2]]:12-[[@LINE-2]]:12}:"{" | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-3]]:13-[[@LINE-3]]:13}:", <# placeholder #>}" | ||
| int *d = c; | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-1]]:3-[[@LINE-1]]:11}:"std::span<int> d" | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-2]]:12-[[@LINE-2]]:12}:"{" | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-3]]:13-[[@LINE-3]]:13}:", <# placeholder #>}" | ||
| int tmp = d[2]; // expected-note{{used in buffer access here}} | ||
| } | ||
|
|
||
| void rhs_span1() { | ||
| int *q = new int[12]; | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-1]]:3-[[@LINE-1]]:11}:"std::span<int> q" | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-2]]:12-[[@LINE-2]]:12}:"{" | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-3]]:23-[[@LINE-3]]:23}:", 12}" | ||
| int *p = q; | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-1]]:3-[[@LINE-1]]:11}:"std::span<int> p" | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-2]]:12-[[@LINE-2]]:12}:"{" | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-3]]:13-[[@LINE-3]]:13}:", <# placeholder #>}" | ||
| p[5] = 10; | ||
| int *r = q; | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-1]]:3-[[@LINE-1]]:11}:"std::span<int> r" | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-2]]:12-[[@LINE-2]]:12}:"{" | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-3]]:13-[[@LINE-3]]:13}:", <# placeholder #>}" | ||
| r[10] = 5; // expected-note{{used in buffer access here}} | ||
| } | ||
|
|
||
| void rhs_span2() { | ||
| int *q = new int[6]; | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-1]]:3-[[@LINE-1]]:11}:"std::span<int> q" | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-2]]:12-[[@LINE-2]]:12}:"{" | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-3]]:22-[[@LINE-3]]:22}:", 6}" | ||
| int *p = q; | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-1]]:3-[[@LINE-1]]:11}:"std::span<int> p" | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-2]]:12-[[@LINE-2]]:12}:"{" | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-3]]:13-[[@LINE-3]]:13}:", <# placeholder #>}" | ||
| p[5] = 10; // expected-note{{used in buffer access here}} | ||
| } | ||
|
|
||
| void rhs_span3() { | ||
| int *q = new int[6]; | ||
| int *p = q; // expected-warning{{'p' is an unsafe pointer used for buffer access}} | ||
| p[5] = 10; // expected-note{{used in buffer access here}} | ||
| int *r = q; | ||
| } | ||
|
|
||
| void test_grouping() { | ||
| int *z = new int[8]; | ||
| int tmp; | ||
| int *y = new int[10]; | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-1]]:3-[[@LINE-1]]:11}:"std::span<int> y" | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-2]]:12-[[@LINE-2]]:12}:"{" | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-3]]:23-[[@LINE-3]]:23}:", 10}" | ||
| tmp = y[5]; | ||
|
|
||
| int *x = new int[10]; | ||
| x = y; | ||
|
|
||
| int *w = z; | ||
| } | ||
|
|
||
| void test_crash() { | ||
| int *r = new int[8]; | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-1]]:3-[[@LINE-1]]:11}:"std::span<int> r" | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-2]]:12-[[@LINE-2]]:12}:"{" | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-3]]:22-[[@LINE-3]]:22}:", 8}" | ||
| int *q = r; | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-1]]:3-[[@LINE-1]]:11}:"std::span<int> q" | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-2]]:12-[[@LINE-2]]:12}:"{" | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-3]]:13-[[@LINE-3]]:13}:", <# placeholder #>}" | ||
| int *p; | ||
| // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-1]]:3-[[@LINE-1]]:9}:"std::span<int> p" | ||
| p = q; | ||
| int tmp = p[9]; // expected-note{{used in buffer access here}} | ||
| } |
51 changes: 51 additions & 0 deletions
51
clang/test/SemaCXX/warn-unsafe-buffer-usage-multi-decl-ptr-init.cpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| // RUN: %clang_cc1 -std=c++20 -Wunsafe-buffer-usage -fsafe-buffer-usage-suggestions -verify %s | ||
|
|
||
| void lhs_span_multi_assign() { | ||
| int *a = new int[2]; | ||
| int *b = a; | ||
| int *c = b; | ||
| int *d = c; // expected-warning{{'d' is an unsafe pointer used for buffer access}} expected-note-re{{{{^change type of 'd' to 'std::span' to preserve bounds information, and change ('a', 'b', and 'c'|'a', 'c', and 'b'|'b', 'a', and 'c'|'b', 'c', and 'a'|'c', 'a', and 'b'|'c', 'b', and 'a') to 'std::span' to propagate bounds information between them$}}}} | ||
| int tmp = d[2]; // expected-note{{used in buffer access here}} | ||
| } | ||
|
|
||
| void rhs_span1() { | ||
| int *q = new int[12]; | ||
| int *p = q; // expected-warning{{'p' is an unsafe pointer used for buffer access}} expected-note-re{{{{^change type of 'p' to 'std::span' to preserve bounds information, and change ('q' and 'r'|'r' and 'q') to 'std::span' to propagate bounds information between them$}}}} | ||
| p[5] = 10; // expected-note{{used in buffer access here}} | ||
| int *r = q; // expected-warning{{'r' is an unsafe pointer used for buffer access}} expected-note-re{{{{^change type of 'r' to 'std::span' to preserve bounds information, and change ('p' and 'q'|'q' and 'p') to 'std::span' to propagate bounds information between them$}}}} | ||
| r[10] = 5; // expected-note{{used in buffer access here}} | ||
| } | ||
|
|
||
| void rhs_span2() { | ||
| int *q = new int[6]; | ||
| int *p = q; // expected-warning{{'p' is an unsafe pointer used for buffer access}} expected-note-re{{{{^change type of 'p' to 'std::span' to preserve bounds information, and change 'q' to 'std::span' to propagate bounds information between them$}}}} | ||
| p[5] = 10; // expected-note{{used in buffer access here}} | ||
| } | ||
|
|
||
| // FIXME: Suggest fixits for p, q, and r since span a valid fixit for r. | ||
| void rhs_span3() { | ||
| int *q = new int[6]; | ||
| int *p = q; // expected-warning{{'p' is an unsafe pointer used for buffer access}} | ||
| p[5] = 10; // expected-note{{used in buffer access here}} | ||
| int *r = q; | ||
| } | ||
|
|
||
| void test_grouping() { | ||
| int *z = new int[8]; | ||
| int tmp; | ||
| int *y = new int[10]; // expected-warning{{'y' is an unsafe pointer used for buffer access}} expected-note-re{{{{^change type of 'y' to 'std::span' to preserve bounds information$}}}} | ||
| tmp = y[5]; // expected-note{{used in buffer access here}} | ||
|
|
||
| int *x = new int[10]; | ||
| x = y; | ||
|
|
||
| int *w = z; | ||
| } | ||
|
|
||
| void test_crash() { | ||
| int *r = new int[8]; | ||
| int *q = r; | ||
| int *p; // expected-warning{{'p' is an unsafe pointer used for buffer access}} expected-note-re{{{{^change type of 'p' to 'std::span' to preserve bounds information, and change ('r' and 'q'|'q' and 'r') to 'std::span' to propagate bounds information between them$}}}} | ||
| p = q; | ||
| int tmp = p[9]; // expected-note{{used in buffer access here}} | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.