Merging r366443:

------------------------------------------------------------------------ r366443 | sammccall | 2019-07-18 17:00:38 +0200 (Thu, 18 Jul 2019) | 1 line [clangd] Disable DumpRecordLayout by default per https://bugs.llvm.org/show_bug.cgi?id=42670 ------------------------------------------------------------------------ llvm-svn: 366713
llvm · Jul 22, 2019 · dc586a6 · dc586a6
1 parent 0382aa1
commit dc586a6
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/clang-tools-extra/clangd/refactor/tweaks/DumpAST.cpp b/clang-tools-extra/clangd/refactor/tweaks/DumpAST.cpp
@@ -128,6 +128,11 @@ class DumpRecordLayout : public Tweak {
         TypeWithKeyword::getTagTypeKindName(Record->getTagKind()));
   }
   Intent intent() const override { return Info; }
+  // FIXME: this is interesting to most users. However:
+  //  - triggering is too broad (e.g. triggers on comments within a class)
+  //  - showMessage has inconsistent UX (e.g. newlines are stripped in VSCode)
+  //  - the output itself is a bit hard to decipher.
+  bool hidden() const override { return true; }
 
 private:
   const RecordDecl *Record = nullptr;