Skip to content

Commit

Permalink
[AIX] Skip unsupported ORC JIT RemoteObjectLayerTest on AIX
Browse files Browse the repository at this point in the history
Summary:
Currently the XCOFF backend does not support writing 64-bit object
files, which the ORC JIT tests will try to exercise if we are on AIX. This patch
selectively disables the tests on AIX for now.

Reviewers: hubert.reinterpretcast, jasonliu, DiggerLin, stevewan, lhames

Reviewed By: hubert.reinterpretcast, lhames

Subscribers: llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D78813
  • Loading branch information
daltenty committed May 1, 2020
1 parent 4c67b11 commit dda0059
Showing 1 changed file with 21 additions and 0 deletions.
21 changes: 21 additions & 0 deletions llvm/unittests/ExecutionEngine/Orc/RemoteObjectLayerTest.cpp
Expand Up @@ -16,6 +16,19 @@
using namespace llvm;
using namespace llvm::orc;

// Writing 64-bit XCOFF isn't supported yet, so we need to disable some tests on
// AIX till it is.
#ifdef _AIX
#define SKIPTEST_IF_UNSUPPORTED() \
do { \
return; \
} while (false)
#else
#define SKIPTEST_IF_UNSUPPORTED() \
do { \
} while (false)
#endif

namespace {

class MockObjectLayer {
Expand Down Expand Up @@ -109,6 +122,7 @@ MockObjectLayer::ObjectPtr createTestObject() {
}

TEST(RemoteObjectLayer, AddObject) {
SKIPTEST_IF_UNSUPPORTED();
llvm::orc::rpc::registerStringError<rpc::RawByteChannel>();
auto TestObject = createTestObject();
if (!TestObject)
Expand Down Expand Up @@ -166,6 +180,7 @@ TEST(RemoteObjectLayer, AddObject) {
}

TEST(RemoteObjectLayer, AddObjectFailure) {
SKIPTEST_IF_UNSUPPORTED();
llvm::orc::rpc::registerStringError<rpc::RawByteChannel>();
auto TestObject = createTestObject();
if (!TestObject)
Expand Down Expand Up @@ -221,6 +236,7 @@ TEST(RemoteObjectLayer, AddObjectFailure) {


TEST(RemoteObjectLayer, RemoveObject) {
SKIPTEST_IF_UNSUPPORTED();
llvm::orc::rpc::registerStringError<rpc::RawByteChannel>();
auto TestObject = createTestObject();
if (!TestObject)
Expand Down Expand Up @@ -268,6 +284,7 @@ TEST(RemoteObjectLayer, RemoveObject) {
}

TEST(RemoteObjectLayer, RemoveObjectFailure) {
SKIPTEST_IF_UNSUPPORTED();
llvm::orc::rpc::registerStringError<rpc::RawByteChannel>();
auto TestObject = createTestObject();
if (!TestObject)
Expand Down Expand Up @@ -324,6 +341,7 @@ TEST(RemoteObjectLayer, RemoveObjectFailure) {
}

TEST(RemoteObjectLayer, FindSymbol) {
SKIPTEST_IF_UNSUPPORTED();
llvm::orc::rpc::registerStringError<rpc::RawByteChannel>();
auto TestObject = createTestObject();
if (!TestObject)
Expand Down Expand Up @@ -406,6 +424,7 @@ TEST(RemoteObjectLayer, FindSymbol) {
}

TEST(RemoteObjectLayer, FindSymbolIn) {
SKIPTEST_IF_UNSUPPORTED();
llvm::orc::rpc::registerStringError<rpc::RawByteChannel>();
auto TestObject = createTestObject();
if (!TestObject)
Expand Down Expand Up @@ -484,6 +503,7 @@ TEST(RemoteObjectLayer, FindSymbolIn) {
}

TEST(RemoteObjectLayer, EmitAndFinalize) {
SKIPTEST_IF_UNSUPPORTED();
llvm::orc::rpc::registerStringError<rpc::RawByteChannel>();
auto TestObject = createTestObject();
if (!TestObject)
Expand Down Expand Up @@ -532,6 +552,7 @@ TEST(RemoteObjectLayer, EmitAndFinalize) {
}

TEST(RemoteObjectLayer, EmitAndFinalizeFailure) {
SKIPTEST_IF_UNSUPPORTED();
llvm::orc::rpc::registerStringError<rpc::RawByteChannel>();
auto TestObject = createTestObject();
if (!TestObject)
Expand Down

0 comments on commit dda0059

Please sign in to comment.