-
Notifications
You must be signed in to change notification settings - Fork 11k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FuncSpec] Prevent assertion failure when no store value is found
If the only user of the Alloca argument provided to getPromotableAlloca() is the same as the Call argument, StoreValue is never set and results in an assertion failure that isa<> was used on a nullptr when passed into getCandidateConstant(). This was originally seen when trying to build SPEC 2006 416.gamess using flang with lto enabled. Differential Revision: https://reviews.llvm.org/D143457
- Loading branch information
1 parent
a69f234
commit dfb98d8
Showing
2 changed files
with
31 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
llvm/test/Transforms/FunctionSpecialization/compiler-crash-promote-alloca.ll
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
; RUN: opt -S --passes="ipsccp<func-spec>" -force-function-specialization < %s | FileCheck %s | ||
|
||
; Tests that `bar` has been specialized and that the compiler did not crash | ||
; while attempting to promote the alloca in `entry`. | ||
; CHECK: bar.1 | ||
|
||
@block = internal global [8 x i8] zeroinitializer, align 1 | ||
|
||
define dso_local void @entry() { | ||
%1 = alloca i32, align 4 | ||
call void @foo(ptr nonnull %1) | ||
ret void | ||
} | ||
|
||
define internal void @foo(ptr nocapture readnone %0) { | ||
%2 = alloca i32, align 4 | ||
call void @bar(ptr nonnull %2, ptr nonnull @block) | ||
call void @bar(ptr nonnull %2, ptr nonnull getelementptr inbounds ([8 x i8], ptr @block, i64 0, i64 4)) | ||
ret void | ||
} | ||
|
||
define internal void @bar(ptr nocapture readonly %0, ptr nocapture readonly %1) { | ||
%3 = load i32, ptr %0, align 4 | ||
%4 = load i32, ptr %1, align 4 | ||
ret void | ||
} | ||
|