Skip to content

Commit

Permalink
[AIX] Fix libc++ Symbol Visibility on AIX
Browse files Browse the repository at this point in the history
The AIX linker does not support linking against libc++ if it exports symbols are redefined within compiled code.

Differential Revision: https://reviews.llvm.org/D140675
  • Loading branch information
KappaMikey1337 committed Mar 8, 2023
1 parent 42cd38c commit e0ecc32
Show file tree
Hide file tree
Showing 2 changed files with 51 additions and 0 deletions.
6 changes: 6 additions & 0 deletions libcxx/include/__config
Expand Up @@ -166,6 +166,12 @@
# if defined(__FreeBSD__)
# define _LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR
# endif
// For XCOFF linkers, we have problems if we see a weak hidden version of a symbol
// in user code (like you get with -fvisibility-inlines-hidden) and then a strong def
// in the library, so we need to always rely on the library version.
# if defined(_AIX)
# define _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION
# endif
# endif

# if defined(_LIBCPP_BUILDING_LIBRARY) || _LIBCPP_ABI_VERSION >= 2
Expand Down
45 changes: 45 additions & 0 deletions libcxx/test/libcxx/vendor/ibm/bad_function_call.pass.cpp
@@ -0,0 +1,45 @@
//===----------------------------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//

// REQUIRES: target={{powerpc.*-ibm-aix.*}}
// ADDITIONAL_COMPILE_FLAGS: -fvisibility-inlines-hidden

// When there is a weak hidden symbol in user code and a strong definition
// in the library, we test that the linker relies on the library version,
// as the default weak resolution semantics don't favour weak local definitions
// for XCOFF. This creates a conflict on std::bad_function_call, which is used
// by the std::function template instantiated in main.
#include <functional>
#include "test_macros.h"
#include "assert.h"

void foo() {}

void test_call() {
std::function<void()> r(foo);
r();
}

void test_throw() {
#ifndef TEST_HAS_NO_EXCEPTIONS
std::function<int()> f;
try {
f();
assert(false);
} catch (const std::bad_function_call&) {
return;
}
assert(false);
#endif // TEST_HAS_NO_EXCEPTIONS
}

int main(int, char**) {
test_call();
test_throw();
return 0;
}

0 comments on commit e0ecc32

Please sign in to comment.