Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[llvm-objdump] Fix alignment issues when dumping offloading sections
Summary: The `.llvm.offloading` section should always be aligned by `8`. However, we may want to show the offloading data stored in a static library. In this case, even though the section's alignment is correct, the offset inside the archive will result in the memory buffer being misaligned. TO combat this we simply check if the buffer does not have the proper alignment and copies it to a new buffer if not. This copy should have the proper alignment.
- Loading branch information
Showing
2 changed files
with
30 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
## Ensure we can read the contents even if the alignment is bad. | ||
# RUN: yaml2obj %s -o %t.elf | ||
# RUN: yaml2obj %S/Inputs/binary.yaml -o %t.bin | ||
# RUN: llvm-objcopy --update-section .llvm.offloading=%t.bin %t.elf | ||
# RUN: llvm-objdump --offloading %t.elf | FileCheck %s -DFILENAME=%t | ||
|
||
!ELF | ||
FileHeader: | ||
Class: ELFCLASS64 | ||
Data: ELFDATA2LSB | ||
Type: ET_EXEC | ||
Sections: | ||
- Name: .misaligned | ||
Type: SHT_PROGBITS | ||
AddressAlign: 0x0000000000000001 | ||
Content: "41424300" | ||
- Name: .llvm.offloading | ||
Type: SHT_LLVM_OFFLOADING | ||
Flags: [ SHF_EXCLUDE ] | ||
AddressAlign: 0x0000000000000001 | ||
|
||
# CHECK-NOT: error: '[[FILENAME]]': while extracting offloading files: Invalid data was encountered while parsing the file |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters