Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Don't produce a dynamic value if there was an error creating it.
We used to make a dynamic value that "pretended to be its parent" but that's hard for some of the more complex ValueObject types, and it's better in this case just to return no dynamic value. Differential Revision: https://reviews.llvm.org/D145629
- Loading branch information
Showing
7 changed files
with
62 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
C_SOURCES := main.c | ||
|
||
include Makefile.rules |
38 changes: 38 additions & 0 deletions
38
lldb/test/API/python_api/value/addr_of_void_star/TestValueAPIAddressOfVoidStar.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
import lldb | ||
from lldbsuite.test.decorators import * | ||
from lldbsuite.test.lldbtest import * | ||
from lldbsuite.test import lldbutil | ||
|
||
class ValueAPIVoidStarTestCase(TestBase): | ||
|
||
def test(self): | ||
self.build() | ||
|
||
target, process, thread, _ = lldbutil.run_to_source_breakpoint(self, | ||
"Break at this line", | ||
lldb.SBFileSpec("main.c")) | ||
frame = thread.GetFrameAtIndex(0) | ||
|
||
# Verify that the expression result for a void * behaves the same way as the | ||
# variable value. | ||
|
||
var_val = frame.FindVariable("void_ptr") | ||
self.assertSuccess(var_val.GetError(), "Var version made correctly") | ||
|
||
expr_val = frame.EvaluateExpression("void_ptr") | ||
self.assertSuccess(expr_val.GetError(), "Expr version succeeds") | ||
|
||
# The pointer values should be equal: | ||
self.assertEqual(var_val.unsigned, expr_val.unsigned, "Values are equal") | ||
|
||
# Both versions should have valid AddressOf, and they should be the same. | ||
|
||
val_addr_of = var_val.AddressOf() | ||
self.assertNotEqual(val_addr_of, lldb.LLDB_INVALID_ADDRESS, "Var addr of right") | ||
|
||
expr_addr_of = expr_val.AddressOf() | ||
self.assertNotEqual(expr_addr_of, lldb.LLDB_INVALID_ADDRESS, "Expr addr of right") | ||
|
||
# The AddressOf values should also be equal. | ||
self.assertEqual(expr_addr_of.unsigned, val_addr_of.unsigned, "Addr of equal") | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
int main (int argc, char const *argv[]) { | ||
char *char_ptr = "Some pointer here"; | ||
void *void_ptr = &char_ptr; | ||
|
||
return 0; // Break at this line | ||
} |