Skip to content

Commit

Permalink
[libc][NFC] remove completed TODOs
Browse files Browse the repository at this point in the history
There were some "TODO" messages that were for things that I have already
completed. This patch removes those.

Reviewed By: michaelrj

Differential Revision: https://reviews.llvm.org/D121232
  • Loading branch information
michaelrj-google committed Mar 8, 2022
1 parent bf0ded8 commit e1dcda9
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 14 deletions.
2 changes: 0 additions & 2 deletions libc/src/__support/str_to_float.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ namespace __llvm_libc {
namespace internal {

template <class T> uint32_t inline leading_zeroes(T inputNumber) {
// TODO(michaelrj): investigate the portability of using something like
// __builtin_clz for specific types.
constexpr uint32_t BITS_IN_T = sizeof(T) * 8;
if (inputNumber == 0) {
return BITS_IN_T;
Expand Down
12 changes: 0 additions & 12 deletions libc/test/src/__support/str_to_float_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -259,18 +259,6 @@ TEST(LlvmLibcStrToFloatTest, SimpleDecimalConversionExtraTypes) {
EXPECT_EQ(double_output_mantissa, uint64_t(0x1AC53A7E04BCDA));
EXPECT_EQ(output_exp2, uint32_t(1089));
EXPECT_EQ(errno, 0);

// TODO(michaelrj): Get long double support working.

// __uint128_t longDoubleOutputMantissa = 0;
// outputExp2 = 0;

// errno = 0;
// __llvm_libc::internal::simple_decimal_conversion<long double>(
// "123456789012345678900", &longDoubleOutputMantissa, &outputExp2);
// EXPECT_EQ(longDoubleOutputMantissa, __uint128_t(0x1AC53A7E04BCDA));
// EXPECT_EQ(outputExp2, uint32_t(1089));
// EXPECT_EQ(errno, 0);
}

#if defined(LONG_DOUBLE_IS_DOUBLE)
Expand Down

0 comments on commit e1dcda9

Please sign in to comment.