Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: There's a fair amount of code duplication between the different ABI plugins for the same architecture (e.g. ABIMacOSX_arm & ABISysV_arm). Deduplicating this code is not very easy at the moment because there is no good place where to put the common code. Instead of creating more plugins, this patch reduces their number by grouping similar plugins into a single folder/plugin. This makes it easy to extract common code to a (e.g.) base class, which can then live in the same folder. The grouping is done based on the underlying llvm target for that architecture, because the plugins already require this for their operation. Reviewers: JDevlieghere, jasonmolenda, jfb Subscribers: sdardis, nemanjai, mgorny, kristof.beyls, fedor.sergeev, kbarton, jrtc27, atanasyan, jsji, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D74138
- Loading branch information
Showing
48 changed files
with
51 additions
and
141 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
5 changes: 3 additions & 2 deletions
5
...e/Plugins/ABI/MacOSX-arm64/CMakeLists.txt → ...source/Plugins/ABI/AArch64/CMakeLists.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion
2
...ource/Plugins/ABI/SysV-arc/CMakeLists.txt → lldb/source/Plugins/ABI/ARC/CMakeLists.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
3 changes: 2 additions & 1 deletion
3
...rce/Plugins/ABI/MacOSX-arm/CMakeLists.txt → lldb/source/Plugins/ABI/ARM/CMakeLists.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,31 +1,5 @@ | ||
if ("AArch64" IN_LIST LLVM_TARGETS_TO_BUILD) | ||
add_subdirectory(MacOSX-arm64) | ||
add_subdirectory(SysV-arm64) | ||
endif() | ||
if ("ARM" IN_LIST LLVM_TARGETS_TO_BUILD) | ||
add_subdirectory(MacOSX-arm) | ||
add_subdirectory(SysV-arm) | ||
endif() | ||
if ("ARC" IN_LIST LLVM_TARGETS_TO_BUILD) | ||
add_subdirectory(SysV-arc) | ||
endif() | ||
if ("Hexagon" IN_LIST LLVM_TARGETS_TO_BUILD) | ||
add_subdirectory(SysV-hexagon) | ||
endif() | ||
if ("Mips" IN_LIST LLVM_TARGETS_TO_BUILD) | ||
add_subdirectory(SysV-mips) | ||
add_subdirectory(SysV-mips64) | ||
endif() | ||
if ("PowerPC" IN_LIST LLVM_TARGETS_TO_BUILD) | ||
add_subdirectory(SysV-ppc) | ||
add_subdirectory(SysV-ppc64) | ||
endif() | ||
if ("SystemZ" IN_LIST LLVM_TARGETS_TO_BUILD) | ||
add_subdirectory(SysV-s390x) | ||
endif() | ||
if ("X86" IN_LIST LLVM_TARGETS_TO_BUILD) | ||
add_subdirectory(SysV-i386) | ||
add_subdirectory(SysV-x86_64) | ||
add_subdirectory(MacOSX-i386) | ||
add_subdirectory(Windows-x86_64) | ||
endif() | ||
foreach(target AArch64 ARM ARC Hexagon Mips PowerPC SystemZ X86) | ||
if (${target} IN_LIST LLVM_TARGETS_TO_BUILD) | ||
add_subdirectory(${target}) | ||
endif() | ||
endforeach() |
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion
2
...e/Plugins/ABI/SysV-hexagon/CMakeLists.txt → ...source/Plugins/ABI/Hexagon/CMakeLists.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
3 changes: 2 additions & 1 deletion
3
...ce/Plugins/ABI/SysV-mips64/CMakeLists.txt → lldb/source/Plugins/ABI/Mips/CMakeLists.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
3 changes: 2 additions & 1 deletion
3
...rce/Plugins/ABI/SysV-ppc64/CMakeLists.txt → ...source/Plugins/ABI/PowerPC/CMakeLists.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion
2
...rce/Plugins/ABI/SysV-s390x/CMakeLists.txt → ...source/Plugins/ABI/SystemZ/CMakeLists.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
5 changes: 4 additions & 1 deletion
5
...Plugins/ABI/Windows-x86_64/CMakeLists.txt → lldb/source/Plugins/ABI/X86/CMakeLists.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters