Skip to content

Commit

Permalink
[Polly] [NFC] [ScopDetection] Make polly-only-func perform regex sc…
Browse files Browse the repository at this point in the history
…op name match.

Summary:

- We were using `.count` in `StringRef`, which matches substrings.
- We may want to use this for equality as well.
- Generalise this, so allow regexes as a parameter to `polly-only-func`.

Differential Revision: https://reviews.llvm.org/D35728

llvm-svn: 308875
  • Loading branch information
bollu committed Jul 24, 2017
1 parent 5b8a909 commit e2699b5
Show file tree
Hide file tree
Showing 2 changed files with 145 additions and 6 deletions.
21 changes: 15 additions & 6 deletions polly/lib/Analysis/ScopDetection.cpp
Expand Up @@ -64,6 +64,7 @@
#include "llvm/IR/IntrinsicInst.h"
#include "llvm/IR/LLVMContext.h"
#include "llvm/Support/Debug.h"
#include "llvm/Support/Regex.h"
#include <set>
#include <stack>

Expand Down Expand Up @@ -92,10 +93,10 @@ static cl::opt<bool, true> XPollyProcessUnprofitable(

static cl::list<std::string> OnlyFunctions(
"polly-only-func",
cl::desc("Only run on functions that contain a certain string. "
"Multiple strings can be comma separated. "
"Scop detection will run on all functions that contain "
"any of the strings provided."),
cl::desc("Only run on functions that match a regex. "
"Multiple regexes can be comma separated. "
"Scop detection will run on all functions that match "
"ANY of the regexes provided."),
cl::ZeroOrMore, cl::CommaSeparated, cl::cat(PollyCategory));

static cl::opt<bool>
Expand Down Expand Up @@ -274,9 +275,17 @@ void DiagnosticScopFound::print(DiagnosticPrinter &DP) const {
}

static bool IsFnNameListedInOnlyFunctions(StringRef FnName) {
for (auto Name : OnlyFunctions)
if (FnName.count(Name) > 0)
for (auto RegexStr : OnlyFunctions) {
Regex R(RegexStr);

std::string Err;
if (!R.isValid(Err))
report_fatal_error(
"invalid regex given as input to -polly-only-func. " + Err, true);

if (R.match(FnName))
return true;
}
return false;
}
//===----------------------------------------------------------------------===//
Expand Down
130 changes: 130 additions & 0 deletions polly/test/ScopDetect/only_func_flag_regex.ll
@@ -0,0 +1,130 @@
; RUN: opt %loadPolly -polly-scops -analyze -polly-only-func=f.*,g.* < %s | FileCheck %s
;
; Check that the flag `-polly-only-func` works with regexes.
;
; CHECK: Function: f1
; CHECK-NEXT: Region: %for.cond---%for.end
;
; CHECK: Function: f2
; CHECK-NEXT: Region: %for.cond---%for.end
;
; CHECK: Function: g1
; CHECK-NEXT: Region: %for.cond---%for.end
;
; CHECK-NOT: Function: h
;
; void f1(int* sum) {
; for (int i = 0; i <= 100; i++)
; sum += i * 3;
; }
; void f2(int* sum) {
; for (int i = 0; i <= 100; i++)
; sum += i * 3;
; }
; void g1(int* sum) {
; for (int i = 0; i <= 100; i++)
; sum += i * 3;
; }
; void h(int* sum) {
; for (int i = 0; i <= 100; i++)
; sum += i * 3;
; }
target datalayout = "e-m:e-p:32:32-i64:64-v128:64:128-n32-S64"

define void @f1(i32* %sum) {
entry:
br label %entry.split1

entry.split1: ; preds = %entry
br label %entry.split

entry.split: ; preds = %entry.split1
br label %for.cond

for.cond: ; preds = %for.cond, %entry.split
%i1.0 = phi i32 [ 0, %entry.split ], [ %inc, %for.cond ]
%sum.reload = load i32, i32* %sum
%mul = mul nsw i32 %i1.0, 3
%add = add nsw i32 %sum.reload, %mul
%inc = add nsw i32 %i1.0, 1
store i32 %add, i32* %sum
%cmp = icmp slt i32 %i1.0, 100
br i1 %cmp, label %for.cond, label %for.end

for.end: ; preds = %for.cond
ret void
}


define void @f2(i32* %sum) {
entry:
br label %entry.split1

entry.split1: ; preds = %entry
br label %entry.split

entry.split: ; preds = %entry.split1
br label %for.cond

for.cond: ; preds = %for.cond, %entry.split
%i1.0 = phi i32 [ 0, %entry.split ], [ %inc, %for.cond ]
%sum.reload = load i32, i32* %sum
%mul = mul nsw i32 %i1.0, 3
%add = add nsw i32 %sum.reload, %mul
%inc = add nsw i32 %i1.0, 1
store i32 %add, i32* %sum
%cmp = icmp slt i32 %i1.0, 100
br i1 %cmp, label %for.cond, label %for.end

for.end: ; preds = %for.cond
ret void
}

define void @g1(i32* %sum) {
entry:
br label %entry.split1

entry.split1: ; preds = %entry
br label %entry.split

entry.split: ; preds = %entry.split1
br label %for.cond

for.cond: ; preds = %for.cond, %entry.split
%i1.0 = phi i32 [ 0, %entry.split ], [ %inc, %for.cond ]
%sum.reload = load i32, i32* %sum
%mul = mul nsw i32 %i1.0, 3
%add = add nsw i32 %sum.reload, %mul
%inc = add nsw i32 %i1.0, 1
store i32 %add, i32* %sum
%cmp = icmp slt i32 %i1.0, 100
br i1 %cmp, label %for.cond, label %for.end

for.end: ; preds = %for.cond
ret void
}

define void @h(i32* %sum) {
entry:
br label %entry.split1

entry.split1: ; preds = %entry
br label %entry.split

entry.split: ; preds = %entry.split1
br label %for.cond

for.cond: ; preds = %for.cond, %entry.split
%i1.0 = phi i32 [ 0, %entry.split ], [ %inc, %for.cond ]
%sum.reload = load i32, i32* %sum
%mul = mul nsw i32 %i1.0, 3
%add = add nsw i32 %sum.reload, %mul
%inc = add nsw i32 %i1.0, 1
store i32 %add, i32* %sum
%cmp = icmp slt i32 %i1.0, 100
br i1 %cmp, label %for.cond, label %for.end

for.end: ; preds = %for.cond
ret void
}

0 comments on commit e2699b5

Please sign in to comment.