Skip to content

Commit

Permalink
fixup! [Clang][OpenMP] Clang adding the addrSpace according to DataLa…
Browse files Browse the repository at this point in the history
…yout fix (#65483)
  • Loading branch information
ajarmusch committed Sep 12, 2023
1 parent 602e509 commit e3298bb
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3362,7 +3362,8 @@ Address CGOpenMPRuntimeGPU::getAddressOfLocalVariable(CodeGenFunction &CGF,
break;
case OMPAllocateDeclAttr::OMPLargeCapMemAlloc:
case OMPAllocateDeclAttr::OMPCGroupMemAlloc:
AS = getLangASFromTargetAS(CGF.CGM.getModule().getDataLayout().getDefaultGlobalsAddressSpace());
AS = getLangASFromTargetAS(
CGF.CGM.getModule().getDataLayout().getDefaultGlobalsAddressSpace());
break;
}
llvm::Type *VarTy = CGF.ConvertTypeForMem(VD->getType());
Expand Down

2 comments on commit e3298bb

@arichardson
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd avoid adding fixup! commits to the main branch, this indicates to me that something went wrong during the merge of a pull request. IMO something like [Clang][OpenMP] Clang-format code added in e831a32c93c1ab404785773cc7c08c01730d61e5 would be better.

@ajarmusch
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Thanks for letting me know

Please sign in to comment.