-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reapply "[analyzer] Accept C library functions from the
std
namespace"
This reapplies f32b04d4ea91ad1018c25a1d4178cc4392d34968i, after fixing the use-after-free of ASTUnit in the unittest. #84469 (comment) Co-authored-by: Balazs Benics <benicsbalazs@gmail.com>
- Loading branch information
Showing
5 changed files
with
93 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
#include "clang/ASTMatchers/ASTMatchFinder.h" | ||
#include "clang/ASTMatchers/ASTMatchers.h" | ||
#include "clang/Analysis/AnalysisDeclContext.h" | ||
#include "clang/Frontend/ASTUnit.h" | ||
#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" | ||
#include "clang/Tooling/Tooling.h" | ||
#include "gtest/gtest.h" | ||
|
||
#include <memory> | ||
|
||
using namespace clang; | ||
using namespace ento; | ||
using namespace ast_matchers; | ||
|
||
class IsCLibraryFunctionTest : public testing::Test { | ||
public: | ||
const FunctionDecl *getFunctionDecl() const { return Result; } | ||
|
||
testing::AssertionResult buildAST(StringRef Code) { | ||
ASTUnit = tooling::buildASTFromCode(Code); | ||
if (!ASTUnit) | ||
return testing::AssertionFailure() << "AST construction failed"; | ||
|
||
ASTContext &Context = ASTUnit->getASTContext(); | ||
if (Context.getDiagnostics().hasErrorOccurred()) | ||
return testing::AssertionFailure() << "Compilation error"; | ||
|
||
auto Matches = ast_matchers::match(functionDecl().bind("fn"), Context); | ||
if (Matches.empty()) | ||
return testing::AssertionFailure() << "No function declaration found"; | ||
|
||
if (Matches.size() > 1) | ||
return testing::AssertionFailure() | ||
<< "Multiple function declarations found"; | ||
|
||
Result = Matches[0].getNodeAs<FunctionDecl>("fn"); | ||
return testing::AssertionSuccess(); | ||
} | ||
|
||
private: | ||
std::unique_ptr<ASTUnit> ASTUnit; | ||
const FunctionDecl *Result = nullptr; | ||
}; | ||
|
||
TEST_F(IsCLibraryFunctionTest, AcceptsGlobal) { | ||
ASSERT_TRUE(buildAST(R"cpp(void fun();)cpp")); | ||
EXPECT_TRUE(CheckerContext::isCLibraryFunction(getFunctionDecl())); | ||
} | ||
|
||
TEST_F(IsCLibraryFunctionTest, AcceptsExternCGlobal) { | ||
ASSERT_TRUE(buildAST(R"cpp(extern "C" { void fun(); })cpp")); | ||
EXPECT_TRUE(CheckerContext::isCLibraryFunction(getFunctionDecl())); | ||
} | ||
|
||
TEST_F(IsCLibraryFunctionTest, RejectsNoInlineNoExternalLinkage) { | ||
// Functions that are neither inlined nor externally visible cannot be C library functions. | ||
ASSERT_TRUE(buildAST(R"cpp(static void fun();)cpp")); | ||
EXPECT_FALSE(CheckerContext::isCLibraryFunction(getFunctionDecl())); | ||
} | ||
|
||
TEST_F(IsCLibraryFunctionTest, RejectsAnonymousNamespace) { | ||
ASSERT_TRUE(buildAST(R"cpp(namespace { void fun(); })cpp")); | ||
EXPECT_FALSE(CheckerContext::isCLibraryFunction(getFunctionDecl())); | ||
} | ||
|
||
TEST_F(IsCLibraryFunctionTest, AcceptsStdNamespace) { | ||
ASSERT_TRUE(buildAST(R"cpp(namespace std { void fun(); })cpp")); | ||
EXPECT_TRUE(CheckerContext::isCLibraryFunction(getFunctionDecl())); | ||
} | ||
|
||
TEST_F(IsCLibraryFunctionTest, RejectsOtherNamespaces) { | ||
ASSERT_TRUE(buildAST(R"cpp(namespace stdx { void fun(); })cpp")); | ||
EXPECT_FALSE(CheckerContext::isCLibraryFunction(getFunctionDecl())); | ||
} | ||
|
||
TEST_F(IsCLibraryFunctionTest, RejectsClassStatic) { | ||
ASSERT_TRUE(buildAST(R"cpp(class A { static void fun(); };)cpp")); | ||
EXPECT_FALSE(CheckerContext::isCLibraryFunction(getFunctionDecl())); | ||
} | ||
|
||
TEST_F(IsCLibraryFunctionTest, RejectsClassMember) { | ||
ASSERT_TRUE(buildAST(R"cpp(class A { void fun(); };)cpp")); | ||
EXPECT_FALSE(CheckerContext::isCLibraryFunction(getFunctionDecl())); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters