Skip to content

Commit

Permalink
[test] Adjust a test to use CHECK-NEXT instead of CHECK-NOT. NFC.
Browse files Browse the repository at this point in the history
Since the order and placement of the non-wanted elements might not
be obvious, it feels more straightforward to hardcode the whole list
with -NEXT elements (and checking for the end of the output with
CHECK-EMPTY) instead of adding CHECK-NOT lines at the right places
where the unwanted elements would appear if they erroneously
were to included.

llvm-svn: 341016
  • Loading branch information
mstorsjo committed Aug 30, 2018
1 parent d3a4cbe commit e5120a3
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions lld/test/COFF/export-all.s
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,13 @@
# RUN: llvm-mc -triple=i686-windows-gnu %s -filetype=obj -o %t.obj

# RUN: lld-link -lldmingw -dll -out:%t.dll -entry:DllMainCRTStartup@12 %t.obj -implib:%t.lib
# RUN: llvm-readobj -coff-exports %t.dll | FileCheck %s
# RUN: llvm-readobj -coff-exports %t.dll | grep Name: | FileCheck %s
# RUN: llvm-readobj %t.lib | FileCheck -check-prefix=IMPLIB %s

# CHECK-NOT: Name: DllMainCRTStartup
# CHECK-NOT: Name: _imp__unexported
# CHECK: Name: dataSym
# CHECK: Name: foobar
# CHECK-NOT: Name: unexported
# CHECK: Name:
# CHECK-NEXT: Name: dataSym
# CHECK-NEXT: Name: foobar
# CHECK-EMPTY:

# IMPLIB: Symbol: __imp__dataSym
# IMPLIB-NOT: Symbol: _dataSym
Expand Down

0 comments on commit e5120a3

Please sign in to comment.