Skip to content

Commit

Permalink
DWARFDIE split out to DWARFBaseDIE
Browse files Browse the repository at this point in the history
This new DWARFBaseDIE is going to be used for DWARFUnit::GetUnitDIEOnly() as
other DIEs are unavailable that time so the caller should not have methods
available to access them.

This patch is only a mechanical split without any use of it.

Differential revision: https://reviews.llvm.org/D47275

llvm-svn: 333222
  • Loading branch information
jankratochvil committed May 24, 2018
1 parent d3efa94 commit e522c97
Show file tree
Hide file tree
Showing 5 changed files with 358 additions and 306 deletions.
1 change: 1 addition & 0 deletions lldb/source/Plugins/SymbolFile/DWARF/CMakeLists.txt
Expand Up @@ -7,6 +7,7 @@ add_lldb_library(lldbPluginSymbolFileDWARF PLUGIN
DWARFASTParserJava.cpp
DWARFASTParserOCaml.cpp
DWARFAttribute.cpp
DWARFBaseDIE.cpp
DWARFCompileUnit.cpp
DWARFDataExtractor.cpp
DWARFDebugAbbrev.cpp
Expand Down
193 changes: 193 additions & 0 deletions lldb/source/Plugins/SymbolFile/DWARF/DWARFBaseDIE.cpp
@@ -0,0 +1,193 @@
//===-- DWARFBaseDIE.cpp ---------------------------------------*- C++ -*-===//
//
// The LLVM Compiler Infrastructure
//
// This file is distributed under the University of Illinois Open Source
// License. See LICENSE.TXT for details.
//
//===----------------------------------------------------------------------===//

#include "DWARFBaseDIE.h"

#include "DWARFUnit.h"
#include "DWARFDebugInfoEntry.h"
#include "SymbolFileDWARF.h"

#include "lldb/Core/Module.h"
#include "lldb/Symbol/ObjectFile.h"

using namespace lldb_private;

DIERef DWARFBaseDIE::GetDIERef() const {
if (!IsValid())
return DIERef();

dw_offset_t cu_offset = m_cu->GetOffset();
if (m_cu->GetBaseObjOffset() != DW_INVALID_OFFSET)
cu_offset = m_cu->GetBaseObjOffset();
return DIERef(cu_offset, m_die->GetOffset());
}

dw_tag_t DWARFBaseDIE::Tag() const {
if (m_die)
return m_die->Tag();
else
return 0;
}

const char *DWARFBaseDIE::GetTagAsCString() const {
return lldb_private::DW_TAG_value_to_name(Tag());
}

const char *DWARFBaseDIE::GetAttributeValueAsString(const dw_attr_t attr,
const char *fail_value) const {
if (IsValid())
return m_die->GetAttributeValueAsString(GetDWARF(), GetCU(), attr,
fail_value);
else
return fail_value;
}

uint64_t DWARFBaseDIE::GetAttributeValueAsUnsigned(const dw_attr_t attr,
uint64_t fail_value) const {
if (IsValid())
return m_die->GetAttributeValueAsUnsigned(GetDWARF(), GetCU(), attr,
fail_value);
else
return fail_value;
}

int64_t DWARFBaseDIE::GetAttributeValueAsSigned(const dw_attr_t attr,
int64_t fail_value) const {
if (IsValid())
return m_die->GetAttributeValueAsSigned(GetDWARF(), GetCU(), attr,
fail_value);
else
return fail_value;
}

uint64_t DWARFBaseDIE::GetAttributeValueAsReference(const dw_attr_t attr,
uint64_t fail_value) const {
if (IsValid())
return m_die->GetAttributeValueAsReference(GetDWARF(), GetCU(), attr,
fail_value);
else
return fail_value;
}

uint64_t DWARFBaseDIE::GetAttributeValueAsAddress(const dw_attr_t attr,
uint64_t fail_value) const {
if (IsValid())
return m_die->GetAttributeValueAsAddress(GetDWARF(), GetCU(), attr,
fail_value);
else
return fail_value;
}

lldb::user_id_t DWARFBaseDIE::GetID() const {
return GetDIERef().GetUID(GetDWARF());
}

const char *DWARFBaseDIE::GetName() const {
if (IsValid())
return m_die->GetName(GetDWARF(), m_cu);
else
return nullptr;
}

lldb::LanguageType DWARFBaseDIE::GetLanguage() const {
if (IsValid())
return m_cu->GetLanguageType();
else
return lldb::eLanguageTypeUnknown;
}

lldb::ModuleSP DWARFBaseDIE::GetModule() const {
SymbolFileDWARF *dwarf = GetDWARF();
if (dwarf)
return dwarf->GetObjectFile()->GetModule();
else
return lldb::ModuleSP();
}

lldb_private::CompileUnit *DWARFBaseDIE::GetLLDBCompileUnit() const {
if (IsValid())
return GetDWARF()->GetCompUnitForDWARFCompUnit(GetCU());
else
return nullptr;
}

dw_offset_t DWARFBaseDIE::GetOffset() const {
if (IsValid())
return m_die->GetOffset();
else
return DW_INVALID_OFFSET;
}

dw_offset_t DWARFBaseDIE::GetCompileUnitRelativeOffset() const {
if (IsValid())
return m_die->GetOffset() - m_cu->GetOffset();
else
return DW_INVALID_OFFSET;
}

SymbolFileDWARF *DWARFBaseDIE::GetDWARF() const {
if (m_cu)
return m_cu->GetSymbolFileDWARF();
else
return nullptr;
}

lldb_private::TypeSystem *DWARFBaseDIE::GetTypeSystem() const {
if (m_cu)
return m_cu->GetTypeSystem();
else
return nullptr;
}

DWARFASTParser *DWARFBaseDIE::GetDWARFParser() const {
lldb_private::TypeSystem *type_system = GetTypeSystem();
if (type_system)
return type_system->GetDWARFParser();
else
return nullptr;
}

bool DWARFBaseDIE::HasChildren() const {
return m_die && m_die->HasChildren();
}

bool DWARFBaseDIE::Supports_DW_AT_APPLE_objc_complete_type() const {
return IsValid() && GetDWARF()->Supports_DW_AT_APPLE_objc_complete_type(m_cu);
}

size_t DWARFBaseDIE::GetAttributes(DWARFAttributes &attributes,
uint32_t depth) const {
if (IsValid()) {
return m_die->GetAttributes(m_cu, m_cu->GetFixedFormSizes(), attributes,
depth);
}
if (depth == 0)
attributes.Clear();
return 0;
}

void DWARFBaseDIE::Dump(lldb_private::Stream *s,
const uint32_t recurse_depth) const {
if (s && IsValid())
m_die->Dump(GetDWARF(), GetCU(), *s, recurse_depth);
}

bool operator==(const DWARFBaseDIE &lhs, const DWARFBaseDIE &rhs) {
return lhs.GetDIE() == rhs.GetDIE() && lhs.GetCU() == rhs.GetCU();
}

bool operator!=(const DWARFBaseDIE &lhs, const DWARFBaseDIE &rhs) {
return !(lhs == rhs);
}

const DWARFDataExtractor &DWARFBaseDIE::GetData() const {
// Clients must check if this DIE is valid before calling this function.
assert(IsValid());
return m_cu->GetData();
}
157 changes: 157 additions & 0 deletions lldb/source/Plugins/SymbolFile/DWARF/DWARFBaseDIE.h
@@ -0,0 +1,157 @@
//===-- DWARFBaseDIE.h -----------------------------------------*- C++ -*-===//
//
// The LLVM Compiler Infrastructure
//
// This file is distributed under the University of Illinois Open Source
// License. See LICENSE.TXT for details.
//
//===----------------------------------------------------------------------===//

#ifndef SymbolFileDWARF_DWARFBaseDIE_h_
#define SymbolFileDWARF_DWARFBaseDIE_h_

#include "lldb/Core/dwarf.h"
#include "lldb/lldb-types.h"

struct DIERef;
class DWARFASTParser;
class DWARFAttributes;
class DWARFUnit;
class DWARFDebugInfoEntry;
class DWARFDeclContext;
class DWARFDIECollection;
class SymbolFileDWARF;

class DWARFBaseDIE {
public:
DWARFBaseDIE() : m_cu(nullptr), m_die(nullptr) {}

DWARFBaseDIE(DWARFUnit *cu, DWARFDebugInfoEntry *die)
: m_cu(cu), m_die(die) {}

DWARFBaseDIE(const DWARFUnit *cu, DWARFDebugInfoEntry *die)
: m_cu(const_cast<DWARFUnit *>(cu)), m_die(die) {}

DWARFBaseDIE(DWARFUnit *cu, const DWARFDebugInfoEntry *die)
: m_cu(cu), m_die(const_cast<DWARFDebugInfoEntry *>(die)) {}

DWARFBaseDIE(const DWARFUnit *cu, const DWARFDebugInfoEntry *die)
: m_cu(const_cast<DWARFUnit *>(cu)),
m_die(const_cast<DWARFDebugInfoEntry *>(die)) {}

//----------------------------------------------------------------------
// Tests
//----------------------------------------------------------------------
explicit operator bool() const { return IsValid(); }

bool IsValid() const { return m_cu && m_die; }

bool HasChildren() const;

bool Supports_DW_AT_APPLE_objc_complete_type() const;

//----------------------------------------------------------------------
// Accessors
//----------------------------------------------------------------------
SymbolFileDWARF *GetDWARF() const;

DWARFUnit *GetCU() const { return m_cu; }

DWARFDebugInfoEntry *GetDIE() const { return m_die; }

DIERef GetDIERef() const;

lldb_private::TypeSystem *GetTypeSystem() const;

DWARFASTParser *GetDWARFParser() const;

void Set(DWARFUnit *cu, DWARFDebugInfoEntry *die) {
if (cu && die) {
m_cu = cu;
m_die = die;
} else {
Clear();
}
}

void Clear() {
m_cu = nullptr;
m_die = nullptr;
}

//----------------------------------------------------------------------
// Get the data that contains the attribute values for this DIE. Support
// for .debug_types means that any DIE can have its data either in the
// .debug_info or the .debug_types section; this method will return the
// correct section data.
//
// Clients must validate that this object is valid before calling this.
//----------------------------------------------------------------------
const lldb_private::DWARFDataExtractor &GetData() const;

//----------------------------------------------------------------------
// Accessing information about a DIE
//----------------------------------------------------------------------
dw_tag_t Tag() const;

const char *GetTagAsCString() const;

dw_offset_t GetOffset() const;

dw_offset_t GetCompileUnitRelativeOffset() const;

//----------------------------------------------------------------------
// Get the LLDB user ID for this DIE. This is often just the DIE offset,
// but it might have a SymbolFileDWARF::GetID() in the high 32 bits if
// we are doing Darwin DWARF in .o file, or DWARF stand alone debug
// info.
//----------------------------------------------------------------------
lldb::user_id_t GetID() const;

const char *GetName() const;

lldb::LanguageType GetLanguage() const;

lldb::ModuleSP GetModule() const;

lldb_private::CompileUnit *GetLLDBCompileUnit() const;

//----------------------------------------------------------------------
// Getting attribute values from the DIE.
//
// GetAttributeValueAsXXX() functions should only be used if you are
// looking for one or two attributes on a DIE. If you are trying to
// parse all attributes, use GetAttributes (...) instead
//----------------------------------------------------------------------
const char *GetAttributeValueAsString(const dw_attr_t attr,
const char *fail_value) const;

uint64_t GetAttributeValueAsUnsigned(const dw_attr_t attr,
uint64_t fail_value) const;

int64_t GetAttributeValueAsSigned(const dw_attr_t attr,
int64_t fail_value) const;

uint64_t GetAttributeValueAsReference(const dw_attr_t attr,
uint64_t fail_value) const;

uint64_t GetAttributeValueAsAddress(const dw_attr_t attr,
uint64_t fail_value) const;

size_t GetAttributes(DWARFAttributes &attributes, uint32_t depth = 0) const;

//----------------------------------------------------------------------
// Pretty printing
//----------------------------------------------------------------------

void Dump(lldb_private::Stream *s, const uint32_t recurse_depth) const;

protected:
DWARFUnit *m_cu;
DWARFDebugInfoEntry *m_die;
};

bool operator==(const DWARFBaseDIE &lhs, const DWARFBaseDIE &rhs);
bool operator!=(const DWARFBaseDIE &lhs, const DWARFBaseDIE &rhs);

#endif // SymbolFileDWARF_DWARFBaseDIE_h_

0 comments on commit e522c97

Please sign in to comment.