Skip to content

Commit

Permalink
[clang][dataflow][NFC] Expand a comment.
Browse files Browse the repository at this point in the history
Reviewed By: sammccall

Differential Revision: https://reviews.llvm.org/D154834
  • Loading branch information
martinboehme committed Jul 11, 2023
1 parent e39c16b commit e53da3e
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,9 @@ static Value *mergeDistinctValues(QualType Type, Value &Val1,
// returns false to avoid storing unneeded values in `DACtx`.
// FIXME: Creating the value based on the type alone creates misshapen values
// for lvalues, since the type does not reflect the need for `ReferenceValue`.
// This issue will be resolved when `ReferenceValue` is eliminated as part
// of the ongoing migration to strict handling of value categories (see
// https://discourse.llvm.org/t/70086 for details).
if (Value *MergedVal = MergedEnv.createValue(Type))
if (Model.merge(Type, Val1, Env1, Val2, Env2, *MergedVal, MergedEnv))
return MergedVal;
Expand Down

0 comments on commit e53da3e

Please sign in to comment.