[X86] Add some tests to show incorrect commuting of vcmpsh instructions.

llvm · Aug 15, 2021 · e5b15c0 · e5b15c0
1 parent 8721490
commit e5b15c0
Showing 1 changed file with 32 additions and 0 deletions.
diff --git a/llvm/test/CodeGen/X86/select-of-half-constants.ll b/llvm/test/CodeGen/X86/select-of-half-constants.ll
@@ -0,0 +1,32 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple=x86_64-- -mattr=+avx512fp16  | FileCheck %s --check-prefixes=X64-AVX512FP16
+
+; This should do a single load into the fp stack for the return, not diddle with xmm registers.
+
+define half @fcmp_select_fp_constants_olt(half %x) nounwind readnone {
+; X64-AVX512FP16-LABEL: fcmp_select_fp_constants_olt:
+; X64-AVX512FP16:       # %bb.0:
+; X64-AVX512FP16-NEXT:    vmovsh {{\.?LCPI[0-9]+_[0-9]+}}(%rip), %xmm1
+; X64-AVX512FP16-NEXT:    vcmpltsh {{\.?LCPI[0-9]+_[0-9]+}}(%rip), %xmm0, %k1
+; X64-AVX512FP16-NEXT:    vmovsh {{\.?LCPI[0-9]+_[0-9]+}}(%rip), %xmm0
+; X64-AVX512FP16-NEXT:    vmovsh %xmm1, %xmm0, %xmm0 {%k1}
+; X64-AVX512FP16-NEXT:    retq
+  %c = fcmp olt half %x, -4.0
+  %r = select i1 %c, half 42.0, half 23.0
+  ret half %r
+}
+
+; FIXME: This should be vcmpgtsh not vcmpltsh.
+define half @fcmp_select_fp_constants_ogt(half %x) nounwind readnone {
+; X64-AVX512FP16-LABEL: fcmp_select_fp_constants_ogt:
+; X64-AVX512FP16:       # %bb.0:
+; X64-AVX512FP16-NEXT:    vcmpltsh {{\.?LCPI[0-9]+_[0-9]+}}(%rip), %xmm0, %k1
+; X64-AVX512FP16-NEXT:    vmovsh {{\.?LCPI[0-9]+_[0-9]+}}(%rip), %xmm1
+; X64-AVX512FP16-NEXT:    vmovsh {{\.?LCPI[0-9]+_[0-9]+}}(%rip), %xmm0
+; X64-AVX512FP16-NEXT:    vmovsh %xmm1, %xmm0, %xmm0 {%k1}
+; X64-AVX512FP16-NEXT:    retq
+  %c = fcmp ogt half %x, -4.0
+  %r = select i1 %c, half 42.0, half 23.0
+  ret half %r
+}
+