Skip to content

Commit

Permalink
[libcxx] [test] Remove --env PATH from the static clangcl config
Browse files Browse the repository at this point in the history
The PATH is set in order to be able to find the tested DLL at runtime.
When linking statically, it's not necessary to set the PATH.

Setting PATH in the executor has the downside that it clears the
existing path (it's not prepended/appended to it), which means
that the executed tools can't find other tools - which sets the
executor-has-no-bash flag.

By removing the unnecessary setting of PATH, we have a properly
working bash even when wrapped by the executor, which gets rid
of the executor-has-no-bash flag in this test configuration, which
makes 9 more testcases be executed.

Differential Revision: https://reviews.llvm.org/D131481
  • Loading branch information
mstorsjo committed Aug 19, 2022
1 parent 3fd4213 commit e78223e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion libcxx/test/configs/llvm-libc++-static-clangcl.cfg.in
Expand Up @@ -11,7 +11,7 @@ config.substitutions.append(('%{link_flags}',
'-nostdlib -L %{lib} -llibc++ -lmsvcrt -lmsvcprt -loldnames'
))
config.substitutions.append(('%{exec}',
'%{executor} --execdir %T --env PATH=%{lib} -- '
'%{executor} --execdir %T -- '
))

import os, site
Expand Down

0 comments on commit e78223e

Please sign in to comment.