Skip to content

Commit

Permalink
Don't move llvm.localescape outside the entry block in the GCOV profi…
Browse files Browse the repository at this point in the history
…ling pass

Summary:
This fixes https://bugs.llvm.org/show_bug.cgi?id=34714.

Patch by Marco Castelluccio

Reviewers: rnk

Reviewed By: rnk

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D38224

llvm-svn: 314201
  • Loading branch information
sylvestre committed Sep 26, 2017
1 parent 5a14bc8 commit e7d4cd6
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion llvm/lib/Transforms/Instrumentation/GCOVProfiling.cpp
Expand Up @@ -502,6 +502,16 @@ static bool functionHasLines(Function &F) {
return false;
}

static bool shouldKeepInEntry(BasicBlock::iterator It) {
if (isa<AllocaInst>(*It)) return true;
if (isa<DbgInfoIntrinsic>(*It)) return true;
if (auto *II = dyn_cast<IntrinsicInst>(It)) {
if (II->getIntrinsicID() == llvm::Intrinsic::localescape) return true;
}

return false;
}

void GCOVProfiler::emitProfileNotes() {
NamedMDNode *CU_Nodes = M->getNamedMetadata("llvm.dbg.cu");
if (!CU_Nodes) return;
Expand Down Expand Up @@ -537,7 +547,7 @@ void GCOVProfiler::emitProfileNotes() {
// single successor, so split the entry block to make sure of that.
BasicBlock &EntryBlock = F.getEntryBlock();
BasicBlock::iterator It = EntryBlock.begin();
while (isa<AllocaInst>(*It) || isa<DbgInfoIntrinsic>(*It))
while (shouldKeepInEntry(It))
++It;
EntryBlock.splitBasicBlock(It);

Expand Down

0 comments on commit e7d4cd6

Please sign in to comment.