Skip to content

Commit

Permalink
add LLVMGetDINodeTag to C bindings
Browse files Browse the repository at this point in the history
Differential Revision: https://reviews.llvm.org/D138415
  • Loading branch information
Davide Bertola authored and adrian-prantl committed Feb 9, 2023
1 parent 91a6df3 commit e87cc8a
Show file tree
Hide file tree
Showing 6 changed files with 44 additions and 1 deletion.
6 changes: 6 additions & 0 deletions llvm/include/llvm-c/DebugInfo.h
Expand Up @@ -1149,6 +1149,12 @@ LLVMMetadataRef LLVMDIBuilderCreateGlobalVariableExpression(
unsigned LineNo, LLVMMetadataRef Ty, LLVMBool LocalToUnit,
LLVMMetadataRef Expr, LLVMMetadataRef Decl, uint32_t AlignInBits);


/**
* Get the dwarf::Tag of a DINode
*/
uint16_t LLVMGetDINodeTag(LLVMMetadataRef MD);

/**
* Retrieves the \c DIVariable associated with this global variable expression.
* \param GVE The global variable expression.
Expand Down
4 changes: 4 additions & 0 deletions llvm/lib/IR/DebugInfo.cpp
Expand Up @@ -1508,6 +1508,10 @@ LLVMDIBuilderCreateArtificialType(LLVMDIBuilderRef Builder,
return wrap(unwrap(Builder)->createArtificialType(unwrapDI<DIType>(Type)));
}

uint16_t LLVMGetDINodeTag(LLVMMetadataRef MD) {
return unwrapDI<DINode>(MD)->getTag();
}

const char *LLVMDITypeGetName(LLVMMetadataRef DType, size_t *Length) {
StringRef Str = unwrap<DIType>(DType)->getName();
*Length = Str.size();
Expand Down
2 changes: 2 additions & 0 deletions llvm/test/Bindings/llvm-c/get-md-tag.ll
@@ -0,0 +1,2 @@
; RUN: llvm-c-test --get-di-tag < /dev/null
; This used to trigger an assertion
28 changes: 27 additions & 1 deletion llvm/tools/llvm-c-test/debuginfo.c
Expand Up @@ -12,10 +12,10 @@
\*===----------------------------------------------------------------------===*/

#include "llvm-c-test.h"
#include "llvm-c/Core.h"
#include "llvm-c/DebugInfo.h"
#include <stdio.h>
#include <string.h>
#include <assert.h>

static LLVMMetadataRef
declare_objc_class(LLVMDIBuilderRef DIB, LLVMMetadataRef File) {
Expand Down Expand Up @@ -201,3 +201,29 @@ int llvm_test_dibuilder(void) {

return 0;
}

int llvm_get_di_tag(void) {
LLVMModuleRef m = LLVMModuleCreateWithName("Mod");
LLVMContextRef context = LLVMGetModuleContext(m);

LLVMMetadataRef metas[] = {LLVMMDStringInContext2(context, "foo", 3)};
LLVMMetadataRef md = LLVMMDNodeInContext2(context, metas, 1);
uint16_t tag0 = LLVMGetDINodeTag(md);

assert(tag0 == 0);

const char *filename = "metadata.c";
LLVMDIBuilderRef builder = LLVMCreateDIBuilder(m);
LLVMMetadataRef file =
LLVMDIBuilderCreateFile(builder, filename, strlen(filename), ".", 1);
LLVMMetadataRef decl = LLVMDIBuilderCreateStructType(
builder, file, "TestClass", 9, file, 42, 64, 0,
LLVMDIFlagObjcClassComplete, NULL, NULL, 0, 0, NULL, NULL, 0);
uint16_t tag1 = LLVMGetDINodeTag(decl);

assert(tag1 == 0x13);

LLVMDisposeModule(m);

return 0;
}
1 change: 1 addition & 0 deletions llvm/tools/llvm-c-test/llvm-c-test.h
Expand Up @@ -37,6 +37,7 @@ int llvm_disassemble(void);

// debuginfo.c
int llvm_test_dibuilder(void);
int llvm_get_di_tag(void);

// metadata.c
int llvm_add_named_metadata_operand(void);
Expand Down
4 changes: 4 additions & 0 deletions llvm/tools/llvm-c-test/main.c
Expand Up @@ -44,6 +44,8 @@ static void print_usage(void) {
fprintf(stderr, " Read lines of triple, hex ascii machine code from stdin "
"- print disassembly\n\n");
fprintf(stderr, " * --calc\n");
fprintf(stderr, " * --get-di-tag\n");
fprintf(stderr, " Run test for getting MDNode dwarf tag\n");
fprintf(stderr, " * --replace-md-operand\n");
fprintf(stderr, " Run test for replacing MDNode operands\n");
fprintf(stderr, " * --is-a-value-as-metadata\n");
Expand Down Expand Up @@ -96,6 +98,8 @@ int main(int argc, char **argv) {
return llvm_add_named_metadata_operand();
} else if (argc == 2 && !strcmp(argv[1], "--set-metadata")) {
return llvm_set_metadata();
} else if (argc == 2 && !strcmp(argv[1], "--get-di-tag")) {
return llvm_get_di_tag();
} else if (argc == 2 && !strcmp(argv[1], "--replace-md-operand")) {
return llvm_replace_md_operand();
} else if (argc == 2 && !strcmp(argv[1], "--is-a-value-as-metadata")) {
Expand Down

0 comments on commit e87cc8a

Please sign in to comment.