Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
------------------------------------------------------------------------ r330976 | gberry | 2018-04-26 14:50:45 -0400 (Thu, 26 Apr 2018) | 15 lines [AArch64] Fix scavenged spill slot base when stack realignment required. Summary: Use the FP for scavenged spill slot accesses to prevent corruption of the callee-save region when the SP is re-aligned. Based on problem and patch reported by @paulwalker-arm This is an alternative to solution proposed in D45770 Reviewers: t.p.northover, paulwalker-arm, thegameg, javed.absar Subscribers: qcolombet, mcrosier, paulwalker-arm, kristof.beyls, rengolin, javed.absar, llvm-commits Differential Revision: https://reviews.llvm.org/D46063 ------------------------------------------------------------------------ llvm-svn: 333223
- Loading branch information
1 parent
ffa16d6
commit e8deffb
Showing
2 changed files
with
45 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
# RUN: llc -mtriple=aarch64-none-linux-gnu -run-pass=prologepilog %s -o - | FileCheck %s | ||
|
||
# Ensure references to scavenged stack slots in the CSR area use the | ||
# FP as a base when the stack pointer must be aligned to something | ||
# larger than required by the target. This is necessary because the | ||
# alignment padding area is between the CSR area and the SP, so the SP | ||
# cannot be used to reference the CSR area. | ||
name: test | ||
tracksRegLiveness: true | ||
frameInfo: | ||
maxAlignment: 64 | ||
# CHECK: stack: | ||
# CHECK: id: 0, name: '', type: default, offset: -64, size: 4, alignment: 64 | ||
# CHECK-NEXT: stack-id: 0 | ||
# CHECK-NEXT: local-offset: -64 | ||
# CHECK: id: 1, name: '', type: default, offset: -20, size: 4, alignment: 4 | ||
# CHECK-NEXT: stack-id: 0 | ||
# CHECK-NEXT: local-offset: -68 | ||
stack: | ||
- { id: 0, size: 4, alignment: 64, local-offset: -64 } | ||
- { id: 1, size: 4, alignment: 4, local-offset: -68 } | ||
|
||
# CHECK: body: | ||
# CHECK: %sp = ANDXri killed %{{x[0-9]+}}, 7865 | ||
# CHECK: STRSui %s0, %sp, 0 | ||
# CHECK: STURSi %s0, %fp, -4 | ||
body: | | ||
bb.0.entry: | ||
liveins: %s0 | ||
STRSui %s0, %stack.0, 0 | ||
STRSui %s0, %stack.1, 0 | ||
; Force preserve a CSR to create a hole in the CSR stack region. | ||
%x28 = IMPLICIT_DEF | ||
RET_ReallyLR |