Skip to content

Commit

Permalink
[libcxx] [test] Fix the get_weekday test on glibc
Browse files Browse the repository at this point in the history
This test feeds in the expected utf8 form of weekdays in various
languages, trying to match what libc++ has gathered internally
from `strftime()`. On glibc, the ru_RU.UTF-8 representation of the
tested weekday is spelled with upper case, while the existing
test reference is lower case.

Differential Revision: https://reviews.llvm.org/D118237
  • Loading branch information
mstorsjo committed Feb 14, 2022
1 parent e5f3628 commit e98f6fa
Showing 1 changed file with 7 additions and 4 deletions.
Expand Up @@ -21,9 +21,6 @@
// get_weekday(iter_type s, iter_type end, ios_base& str,
// ios_base::iostate& err, tm* t) const;

// TODO: investigation needed
// XFAIL: target={{.*}}-linux-gnu{{.*}}

#include <locale>
#include <cassert>
#include "test_macros.h"
Expand Down Expand Up @@ -70,7 +67,13 @@ int main(int, char**)
}
{
const my_facet f(LOCALE_ru_RU_UTF_8, 1);
const char in[] = "\xD0\xBF\xD0\xBE\xD0\xBD\xD0\xB5"
const char in[] =
#ifdef TEST_HAS_GLIBC
"\xD0\x9F" // Upper case
#else
"\xD0\xBF" // Lower case
#endif
"\xD0\xBE\xD0\xBD\xD0\xB5"
"\xD0\xB4\xD0\xB5\xD0\xBB\xD1\x8C"
"\xD0\xBD\xD0\xB8\xD0\xBA";
err = std::ios_base::goodbit;
Expand Down

0 comments on commit e98f6fa

Please sign in to comment.