-
Notifications
You must be signed in to change notification settings - Fork 10.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
AMDGPU/SI: Remove assert from AMDGPUOpenCLImageTypeLowering pass
Summary: Instead of asserting when the kernel metadata is different than we expect, we should just skip lowering that function. This fixes assertion failures with OpenCL argument metadata from older LLVM releases. Reviewers: arsenm Subscribers: arsenm, llvm-commits Differential Revision: http://reviews.llvm.org/D13356 llvm-svn: 249073
- Loading branch information
1 parent
8587212
commit e9f8b24
Showing
2 changed files
with
30 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
; RUN: llc < %s -march=r600 -mcpu=redwood | FileCheck --check-prefix=EG --check-prefix=FUNC %s | ||
; RUN: llc < %s -march=amdgcn -mcpu=SI -verify-machineinstrs | FileCheck --check-prefix=SI --check-prefix=FUNC %s | ||
|
||
; Make sure the OpenCL Image lowering pass doesn't crash when argument metadata | ||
; is not in expected order. | ||
|
||
; EG: CF_END | ||
; SI: s_endpgm | ||
define void @kernel(i32 addrspace(1)* %out) { | ||
entry: | ||
store i32 0, i32 addrspace(1)* %out | ||
ret void | ||
} | ||
|
||
attributes #3 = { nounwind } | ||
|
||
!opencl.kernels = !{!0} | ||
|
||
!0 = !{void (i32 addrspace(1)*)* @kernel, !1, !2, !3, !4, !5} | ||
!1 = !{!"kernel_arg_addr_space", i32 0} | ||
!2 = !{!"kernel_arg_access_qual", !"none"} | ||
!3 = !{!"kernel_arg_type", !"int*"} | ||
!4 = !{!"kernel_arg_type_qual", !""} | ||
!5 = !{!"kernel_arg_name", !""} |