[libcxx] [test] Add a 'win32-' prefix to the 'broken-utf8-wchar-ctype…

…' feature This was suggested in the review of https://reviews.llvm.org/D120022. Also indent the code for the compilation test one step compared to the surrounding expression. Differential Revision: https://reviews.llvm.org/D120469
llvm · Mar 1, 2022 · eb4dcc7 · eb4dcc7
1 parent 2614192
commit eb4dcc7
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 12 deletions.
diff --git a/.../std/localization/locale.categories/category.ctype/locale.ctype.byname/tolower_1.pass.cpp b/.../std/localization/locale.categories/category.ctype/locale.ctype.byname/tolower_1.pass.cpp
@@ -7,7 +7,7 @@
 //===----------------------------------------------------------------------===//
 
 // REQUIRES: locale.en_US.UTF-8
-// XFAIL: broken-utf8-wchar-ctype
+// XFAIL: win32-broken-utf8-wchar-ctype
 
 // <locale>
 

diff --git a/...d/localization/locale.categories/category.ctype/locale.ctype.byname/tolower_many.pass.cpp b/...d/localization/locale.categories/category.ctype/locale.ctype.byname/tolower_many.pass.cpp
@@ -7,7 +7,7 @@
 //===----------------------------------------------------------------------===//
 
 // REQUIRES: locale.en_US.UTF-8
-// XFAIL: broken-utf8-wchar-ctype
+// XFAIL: win32-broken-utf8-wchar-ctype
 
 // <locale>
 

diff --git a/.../std/localization/locale.categories/category.ctype/locale.ctype.byname/toupper_1.pass.cpp b/.../std/localization/locale.categories/category.ctype/locale.ctype.byname/toupper_1.pass.cpp
@@ -7,7 +7,7 @@
 //===----------------------------------------------------------------------===//
 
 // REQUIRES: locale.en_US.UTF-8
-// XFAIL: broken-utf8-wchar-ctype
+// XFAIL: win32-broken-utf8-wchar-ctype
 
 // <locale>
 

diff --git a/...d/localization/locale.categories/category.ctype/locale.ctype.byname/toupper_many.pass.cpp b/...d/localization/locale.categories/category.ctype/locale.ctype.byname/toupper_many.pass.cpp
@@ -7,7 +7,7 @@
 //===----------------------------------------------------------------------===//
 
 // REQUIRES: locale.en_US.UTF-8
-// XFAIL: broken-utf8-wchar-ctype
+// XFAIL: win32-broken-utf8-wchar-ctype
 
 // <locale>
 

diff --git a/libcxx/test/std/re/re.traits/translate_nocase.pass.cpp b/libcxx/test/std/re/re.traits/translate_nocase.pass.cpp
@@ -13,7 +13,7 @@
 // charT translate_nocase(charT c) const;
 
 // REQUIRES: locale.en_US.UTF-8
-// XFAIL: broken-utf8-wchar-ctype
+// XFAIL: win32-broken-utf8-wchar-ctype
 
 #include <regex>
 #include <cassert>

diff --git a/libcxx/utils/libcxx/test/features.py b/libcxx/utils/libcxx/test/features.py
@@ -75,14 +75,14 @@
 
   # Check for a Windows UCRT bug (fixed in UCRT/Windows 10.0.20348.0):
   # https://developercommunity.visualstudio.com/t/utf-8-locales-break-ctype-functions-for-wchar-type/1653678
-  Feature(name='broken-utf8-wchar-ctype',
+  Feature(name='win32-broken-utf8-wchar-ctype',
           when=lambda cfg: '_WIN32' in compilerMacros(cfg) and not programSucceeds(cfg, """
-          #include <locale.h>
-          #include <wctype.h>
-          int main(int, char**) {
-            setlocale(LC_ALL, "en_US.UTF-8");
-            return towlower(L'\\xDA') != L'\\xFA';
-          }
+            #include <locale.h>
+            #include <wctype.h>
+            int main(int, char**) {
+              setlocale(LC_ALL, "en_US.UTF-8");
+              return towlower(L'\\xDA') != L'\\xFA';
+            }
           """)),
 
   # Whether Bash can run on the executor.