Update SWIG typemaps to use PythonFile.

Using the Python native C API is non-portable across Python versions, so this patch changes them to use the `PythonFile` class which hides the version specific differences behind a single interface. llvm-svn: 250525
llvm · Oct 16, 2015 · eda01c3 · eda01c3
1 parent 53bd975
commit eda01c3
Show file tree

Hide file tree

Showing 3 changed files with 44 additions and 13 deletions.
diff --git a/lldb/scripts/Python/python-typemaps.swig b/lldb/scripts/Python/python-typemaps.swig
@@ -503,27 +503,31 @@
 %typemap(in) FILE * {
    if ($input == Py_None)
       $1 = NULL;
-   else if (!PyFile_Check($input)) {
+   else if (!lldb_private::PythonFile::Check($input)) {
       int fd = PyObject_AsFileDescriptor($input);
-      PyObject *py_mode = PyObject_GetAttrString($input, "mode");
-      if (!py_mode) {
-         PyErr_SetString(PyExc_TypeError,"not a file-like object");
-         return NULL;
-      }
-      const char *mode = PyString_AsString(py_mode);
-      if (-1 != fd && mode) {
+      lldb_private::PythonString py_mode(lldb_private::PyRefType::Owned,
+		  PyObject_GetAttrString($input, "mode"));
+
+      if (-1 != fd && py_mode.IsValid()) {
          FILE *f;
-         if ((f = fdopen(fd, mode)))
+         if ((f = fdopen(fd, py_mode.GetString().str().c_str())))
             $1 = f;
          else
             PyErr_SetString(PyExc_TypeError, strerror(errno));
       } else {
          PyErr_SetString(PyExc_TypeError,"not a file-like object");
-         return NULL;
+         return nullptr;
       }
    }
    else
-      $1 = PyFile_AsFile($input);
+   {
+      lldb_private::File file;
+	    lldb_private::PythonFile py_file(lldb_private::PyRefType::Borrowed, $input);
+	    if (!py_file.GetUnderlyingFile(file))
+	      return nullptr;
+
+      $1 = file.GetStream();
+   }
 }
 
 %typemap(out) FILE * {
@@ -539,7 +543,9 @@
    else // if (flags & __SRW)
       mode[i++] = 'a';
 #endif
-   $result = PyFile_FromFile($1, const_cast<char*>(""), mode, fflush);
+   lldb_private::File file($1, false);
+   lldb_private::PythonFile py_file(file, mode);
+   $result = py_file.release();
 }
 
 %typemap(in) (const char* string, int len) {

diff --git a/lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp b/lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp
@@ -582,6 +582,14 @@ PythonFile::PythonFile(File &file, const char *mode)
     Reset(file, mode);
 }
 
+PythonFile::PythonFile(const char *path, const char *mode)
+{
+    FILE *fp = nullptr;
+    fp = fopen(path, mode);
+    lldb_private::File file(fp, true);
+    Reset(file, mode);
+}
+
 PythonFile::PythonFile(PyRefType type, PyObject *o)
 {
     Reset(type, o);
@@ -651,4 +659,18 @@ PythonFile::Reset(File &file, const char *mode)
 #endif
 }
 
+bool
+PythonFile::GetUnderlyingFile(File &file) const
+{
+    if (!IsValid())
+        return false;
+
+    file.Close();
+    // We don't own the file descriptor returned by this function, make sure the
+    // File object knows about that.
+    file.SetDescriptor(PyObject_AsFileDescriptor(m_py_obj), false);
+    return file.IsValid();
+}
+
+
 #endif
diff --git a/lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h b/lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h
@@ -323,7 +323,8 @@ class PythonDictionary : public PythonObject
 class PythonFile : public PythonObject
 {
   public:
-    explicit PythonFile(File &file, const char *mode);
+    PythonFile(File &file, const char *mode);
+    PythonFile(const char *path, const char *mode);
     PythonFile(PyRefType type, PyObject *o);
     ~PythonFile() override;
 
@@ -333,6 +334,8 @@ class PythonFile : public PythonObject
 
     void Reset(PyRefType type, PyObject *py_obj) override;
     void Reset(File &file, const char *mode);
+
+    bool GetUnderlyingFile(File &file) const;
 };
 
 } // namespace lldb_private