Skip to content

Commit

Permalink
[Reassociate][test] Delete improper -NOT patterns to work with -enabl…
Browse files Browse the repository at this point in the history
…e-new-pm=1

The two tests rely on LegacyInlinerBase::doFinalization to remove
Function::isDefTriviallyDead() functions. The new PM does not have the behavior.
The -NEXT patterns checking the emptiness are actually sufficient.

Note, reassociate-deadinst.ll has become stale - it no longer catches
the problem r285380 intended. Unfortunately it is difficult to craft a
new test because it is actually pretty difficult to break it with
`MadeChange = true;` all over the file.
  • Loading branch information
MaskRay committed Oct 29, 2020
1 parent 08bb5d9 commit ee7e03e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion llvm/test/Transforms/Reassociate/erase_inst_made_change.ll
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ entry:
}

define internal void @bar() noinline nounwind readnone {
; CHECK-NOT: bar
entry:
ret void
}
Expand Down
1 change: 0 additions & 1 deletion llvm/test/Transforms/Reassociate/reassociate-deadinst.ll
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
; RUN: opt < %s -inline -function-attrs -reassociate -S | FileCheck %s

; CHECK-NOT: func1
; CHECK-LABEL: main
; CHECK-NEXT: ret void

Expand Down

0 comments on commit ee7e03e

Please sign in to comment.