Skip to content

Commit

Permalink
Remove one change from https://reviews.llvm.org/D115431
Browse files Browse the repository at this point in the history
The change to ArchSpec::SetArchitecture that was setting the
ObjectFile of a mach-o binary to llvm::Triple::MachO.  It's not
necessary for my patch, and it changes the output of image list -t
causing TestUniversal.py to fail on x86_64 systems.  The bots
turned up the failure, I was developing and testing this on
an Apple Silicon mac.
  • Loading branch information
jasonmolenda committed Dec 10, 2021
1 parent e6e7da5 commit efdac16
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion lldb/source/Utility/ArchSpec.cpp
Expand Up @@ -859,7 +859,6 @@ bool ArchSpec::SetArchitecture(ArchitectureType arch_type, uint32_t cpu,
m_triple.setArchName(llvm::StringRef(core_def->name));
if (arch_type == eArchTypeMachO) {
m_triple.setVendor(llvm::Triple::Apple);
m_triple.setObjectFormat(llvm::Triple::MachO);

// Don't set the OS. It could be simulator, macosx, ios, watchos,
// tvos, bridgeos. We could get close with the cpu type - but we
Expand Down

0 comments on commit efdac16

Please sign in to comment.