Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FastISel] Don't trivially kill extractvalues (PR49467)
All extractvalues of the same value at the same index will map to the same register, so even if one specific extractvalue only has one use, we should not mark it as a trivial kill, as there may be more extractvalues later. Fixes https://bugs.llvm.org/show_bug.cgi?id=49467. Differential Revision: https://reviews.llvm.org/D98145 (cherry picked from commit 55ae279)
- Loading branch information
Showing
3 changed files
with
38 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py | ||
; RUN: llc -O0 -fast-isel -verify-machineinstrs -mtriple=x86_64 < %s | FileCheck %s | ||
|
||
declare { i8*, i64 } @get() | ||
|
||
declare void @use(i8*, i64) | ||
|
||
define void @test(i64* %p) nounwind { | ||
; CHECK-LABEL: test: | ||
; CHECK: # %bb.0: | ||
; CHECK-NEXT: pushq %rax | ||
; CHECK-NEXT: movq %rdi, (%rsp) # 8-byte Spill | ||
; CHECK-NEXT: callq get@PLT | ||
; CHECK-NEXT: movq (%rsp), %rdi # 8-byte Reload | ||
; CHECK-NEXT: movq %rdx, %rsi | ||
; CHECK-NEXT: movq %rsi, (%rdi) | ||
; CHECK-NEXT: # implicit-def: $rdi | ||
; CHECK-NEXT: callq use@PLT | ||
; CHECK-NEXT: popq %rax | ||
; CHECK-NEXT: retq | ||
%struct = call { i8*, i64 } @get() | ||
%struct.1 = extractvalue { i8*, i64 } %struct, 1 | ||
store i64 %struct.1, i64* %p, align 8 | ||
%struct.2 = extractvalue { i8*, i64 } %struct, 1 | ||
call void @use(i8* undef, i64 %struct.2) | ||
ret void | ||
} |