Skip to content

Commit

Permalink
AMDGPU/SI: Don't promote alloca to vector for AddrSpaceCast instruction.
Browse files Browse the repository at this point in the history
Summary:
  We have no logic to promote alloca to vector for an AddrSpaceCast instruction.

Reviewer:
  arsenm

Differential Revision:
  https://reviews.llvm.org/D45993

llvm-svn: 332147
  • Loading branch information
Changpeng Fang committed May 11, 2018
1 parent a17d627 commit f094885
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 1 deletion.
1 change: 0 additions & 1 deletion llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp
Expand Up @@ -328,7 +328,6 @@ static bool canVectorizeInst(Instruction *Inst, User *User) {
return isa<GetElementPtrInst>(LI->getPointerOperand()) && !LI->isVolatile();
}
case Instruction::BitCast:
case Instruction::AddrSpaceCast:
return true;
case Instruction::Store: {
// Must be the stored pointer operand, not a stored value, plus
Expand Down
27 changes: 27 additions & 0 deletions llvm/test/CodeGen/AMDGPU/vector-alloca-addrspacecast.ll
@@ -0,0 +1,27 @@
; RUN: opt -S -mtriple=amdgcn-- -data-layout=A5 -amdgpu-promote-alloca -sroa -instcombine < %s | FileCheck -check-prefix=OPT %s

; Should give up promoting alloca to vector with an addrspacecast.

; OPT-LABEL: @vector_addrspacecast(
; OPT: alloca [3 x i32]
; OPT: store i32 0, i32 addrspace(5)* %a0, align 4
; OPT: store i32 1, i32 addrspace(5)* %a1, align 4
; OPT: store i32 2, i32 addrspace(5)* %a2, align 4
; OPT: %tmp = getelementptr [3 x i32], [3 x i32] addrspace(5)* %alloca, i64 0, i64 %index
; OPT: %ac = addrspacecast i32 addrspace(5)* %tmp to i32*
; OPT: %data = load i32, i32* %ac, align 4
define amdgpu_kernel void @vector_addrspacecast(i32 addrspace(1)* %out, i64 %index) {
entry:
%alloca = alloca [3 x i32], addrspace(5)
%a0 = getelementptr [3 x i32], [3 x i32] addrspace(5)* %alloca, i32 0, i32 0
%a1 = getelementptr [3 x i32], [3 x i32] addrspace(5)* %alloca, i32 0, i32 1
%a2 = getelementptr [3 x i32], [3 x i32] addrspace(5)* %alloca, i32 0, i32 2
store i32 0, i32 addrspace(5)* %a0
store i32 1, i32 addrspace(5)* %a1
store i32 2, i32 addrspace(5)* %a2
%tmp = getelementptr [3 x i32], [3 x i32] addrspace(5)* %alloca, i64 0, i64 %index
%ac = addrspacecast i32 addrspace(5)* %tmp to i32 *
%data = load i32, i32 * %ac
store i32 %data, i32 addrspace(1)* %out
ret void
}

0 comments on commit f094885

Please sign in to comment.