Skip to content

Commit

Permalink
[Sema][SVE] Add tests for valid and invalid type usage
Browse files Browse the repository at this point in the history
This patch adds C and C++ tests for various uses of SVE types.
The tests cover valid uses that are already (correctly) accepted and
invalid uses that are already (correctly) rejected.  Later patches
will expand the tests as they fix other cases.[*]

Some of the tests for invalid uses aren't obviously related to
scalable vectors.  Part of the reason for having them is to make
sure that the quality of the error message doesn't regress once/if
the types are treated as incomplete types.

[*] These later patches all fix invalid uses that are being incorrectly
    accepted.  I don't know of any cases in which valid uses are being
    incorrectly rejected.  In other words, this series is all about
    diagnosing invalid code rather than enabling something new.

Differential Revision: https://reviews.llvm.org/D75571
  • Loading branch information
rsandifo-arm committed Mar 12, 2020
1 parent 7bfc3bf commit f09c7d6
Show file tree
Hide file tree
Showing 2 changed files with 691 additions and 0 deletions.
222 changes: 222 additions & 0 deletions clang/test/Sema/sizeless-1.c
@@ -0,0 +1,222 @@
// RUN: %clang_cc1 -fsyntax-only -verify -Wall -W -Wno-comment -triple arm64-linux-gnu -target-feature +sve -std=c90 %s
// RUN: %clang_cc1 -fsyntax-only -verify -Wall -W -triple arm64-linux-gnu -target-feature +sve -std=c11 %s
// RUN: %clang_cc1 -fsyntax-only -verify -Wall -W -triple arm64-linux-gnu -target-feature +sve -std=gnu11 %s

typedef __SVInt8_t svint8_t;
typedef __SVInt16_t svint16_t;

svint8_t *global_int8_ptr;
extern svint8_t *extern_int8_ptr;
static svint8_t *static_int8_ptr;

typedef svint8_t int8_typedef;
typedef svint8_t *int8_ptr_typedef;

void pass_int8(svint8_t); // expected-note {{passing argument to parameter here}}

svint8_t return_int8();

typedef svint8_t vec_int8_a __attribute__((vector_size(64))); // expected-error {{invalid vector element type}}
typedef svint8_t vec_int8_b __attribute__((ext_vector_type(4))); // expected-error {{invalid vector element type}}

void dump(const volatile void *);

void __attribute__((overloadable)) overf(svint8_t);
void __attribute__((overloadable)) overf(svint16_t);

void __attribute__((overloadable)) overf8(svint8_t); // expected-note + {{not viable}}
void __attribute__((overloadable)) overf8(int); // expected-note + {{not viable}}

void __attribute__((overloadable)) overf16(svint16_t); // expected-note + {{not viable}}
void __attribute__((overloadable)) overf16(int); // expected-note + {{not viable}}

void noproto();
void varargs(int, ...);

void unused() {
svint8_t unused_int8; // expected-warning {{unused}}
}

struct incomplete_struct *incomplete_ptr;

void func(int sel) {
svint8_t local_int8;
svint16_t local_int16;

// Using pointers to sizeless data isn't wrong here, but because the
// type is incomplete, it doesn't provide any alignment guarantees.
_Static_assert(__atomic_is_lock_free(1, &local_int8) == __atomic_is_lock_free(1, incomplete_ptr), "");
_Static_assert(__atomic_is_lock_free(2, &local_int8) == __atomic_is_lock_free(2, incomplete_ptr), ""); // expected-error {{static_assert expression is not an integral constant expression}}
_Static_assert(__atomic_always_lock_free(1, &local_int8) == __atomic_always_lock_free(1, incomplete_ptr), "");

local_int8; // expected-warning {{expression result unused}}

(void)local_int8;

local_int8, 0; // expected-warning + {{expression result unused}}

0, local_int8; // expected-warning + {{expression result unused}}

svint8_t init_int8 = local_int8;
svint8_t bad_init_int8 = for; // expected-error {{expected expression}}

int empty_brace_init_int = {}; // expected-error {{scalar initializer cannot be empty}}

const svint8_t const_int8 = local_int8; // expected-note {{declared const here}}
const svint8_t uninit_const_int8;

volatile svint8_t volatile_int8;

const volatile svint8_t const_volatile_int8 = local_int8; // expected-note {{declared const here}}
const volatile svint8_t uninit_const_volatile_int8;

__restrict svint8_t restrict_int8; // expected-error {{requires a pointer or reference}}

_Bool test_int8 = init_int8; // expected-error {{initializing '_Bool' with an expression of incompatible type 'svint8_t'}}

int int_int8 = init_int8; // expected-error {{initializing 'int' with an expression of incompatible type 'svint8_t'}}

init_int8 = local_int8;
init_int8 = local_int16; // expected-error {{assigning to 'svint8_t' (aka '__SVInt8_t') from incompatible type 'svint16_t'}}
init_int8 = sel; // expected-error {{assigning to 'svint8_t' (aka '__SVInt8_t') from incompatible type 'int'}}

sel = local_int8; // expected-error {{assigning to 'int' from incompatible type 'svint8_t'}}

local_int8 = (svint8_t)local_int16; // expected-error {{used type 'svint8_t' (aka '__SVInt8_t') where arithmetic or pointer type is required}}
local_int8 = (svint8_t)0; // expected-error {{used type 'svint8_t' (aka '__SVInt8_t') where arithmetic or pointer type is required}}
sel = (int)local_int8; // expected-error {{operand of type 'svint8_t' (aka '__SVInt8_t') where arithmetic or pointer type is required}}

init_int8 = local_int8;
init_int8 = const_int8;
init_int8 = volatile_int8;
init_int8 = const_volatile_int8;

const_int8 = local_int8; // expected-error {{cannot assign to variable 'const_int8' with const-qualified type 'const svint8_t'}}

volatile_int8 = local_int8;
volatile_int8 = const_int8;
volatile_int8 = volatile_int8;
volatile_int8 = const_volatile_int8;

const_volatile_int8 = local_int8; // expected-error {{cannot assign to variable 'const_volatile_int8' with const-qualified type 'const volatile svint8_t'}}

pass_int8(local_int8);
pass_int8(local_int16); // expected-error {{passing 'svint16_t' (aka '__SVInt16_t') to parameter of incompatible type 'svint8_t'}}

local_int8 = return_int8();
local_int16 = return_int8(); // expected-error {{assigning to 'svint16_t' (aka '__SVInt16_t') from incompatible type 'svint8_t'}}

dump(&local_int8);
dump(&const_int8);
dump(&volatile_int8);
dump(&const_volatile_int8);

*&local_int8 = local_int8;
*&const_int8 = local_int8; // expected-error {{read-only variable is not assignable}}
*&volatile_int8 = local_int8;
*&const_volatile_int8 = local_int8; // expected-error {{read-only variable is not assignable}}

overf(local_int8);
overf(local_int16);

overf8(local_int8);
overf8(local_int16); // expected-error {{no matching function}}

overf16(local_int8); // expected-error {{no matching function}}
overf16(local_int16);

noproto(local_int8);
varargs(1, local_int8, local_int16);

+init_int8; // expected-error {{invalid argument type 'svint8_t'}}
++init_int8; // expected-error {{cannot increment value of type 'svint8_t'}}
init_int8++; // expected-error {{cannot increment value of type 'svint8_t'}}
-init_int8; // expected-error {{invalid argument type 'svint8_t'}}
--init_int8; // expected-error {{cannot decrement value of type 'svint8_t'}}
init_int8--; // expected-error {{cannot decrement value of type 'svint8_t'}}
~init_int8; // expected-error {{invalid argument type 'svint8_t'}}
!init_int8; // expected-error {{invalid argument type 'svint8_t'}}
*init_int8; // expected-error {{indirection requires pointer operand}}
__real init_int8; // expected-error {{invalid type 'svint8_t'}}
__imag init_int8; // expected-error {{invalid type 'svint8_t'}}

local_int8 + init_int8; // expected-error {{invalid operands to binary expression}}
local_int8 - init_int8; // expected-error {{invalid operands to binary expression}}
local_int8 *init_int8; // expected-error {{invalid operands to binary expression}}
local_int8 / init_int8; // expected-error {{invalid operands to binary expression}}
local_int8 % init_int8; // expected-error {{invalid operands to binary expression}}
local_int8 &init_int8; // expected-error {{invalid operands to binary expression}}
local_int8 | init_int8; // expected-error {{invalid operands to binary expression}}
local_int8 ^ init_int8; // expected-error {{invalid operands to binary expression}}
local_int8 << init_int8; // expected-error {{invalid operands to binary expression}}
local_int8 >> init_int8; // expected-error {{invalid operands to binary expression}}
local_int8 < init_int8; // expected-error {{invalid operands to binary expression}}
local_int8 <= init_int8; // expected-error {{invalid operands to binary expression}}
local_int8 == init_int8; // expected-error {{invalid operands to binary expression}}
local_int8 != init_int8; // expected-error {{invalid operands to binary expression}}
local_int8 >= init_int8; // expected-error {{invalid operands to binary expression}}
local_int8 > init_int8; // expected-error {{invalid operands to binary expression}}
local_int8 &&init_int8; // expected-error {{invalid operands to binary expression}}
local_int8 || init_int8; // expected-error {{invalid operands to binary expression}}

local_int8 += init_int8; // expected-error {{invalid operands to binary expression}}
local_int8 -= init_int8; // expected-error {{invalid operands to binary expression}}
local_int8 *= init_int8; // expected-error {{invalid operands to binary expression}}
local_int8 /= init_int8; // expected-error {{invalid operands to binary expression}}
local_int8 %= init_int8; // expected-error {{invalid operands to binary expression}}
local_int8 &= init_int8; // expected-error {{invalid operands to binary expression}}
local_int8 |= init_int8; // expected-error {{invalid operands to binary expression}}
local_int8 ^= init_int8; // expected-error {{invalid operands to binary expression}}
local_int8 <<= init_int8; // expected-error {{invalid operands to binary expression}}
local_int8 >>= init_int8; // expected-error {{invalid operands to binary expression}}

local_int8 + 0; // expected-error {{invalid operands to binary expression}}
local_int8 - 0; // expected-error {{invalid operands to binary expression}}
local_int8 * 0; // expected-error {{invalid operands to binary expression}}
local_int8 / 0; // expected-error {{invalid operands to binary expression}}
local_int8 % 0; // expected-error {{invalid operands to binary expression}}
local_int8 & 0; // expected-error {{invalid operands to binary expression}}
local_int8 | 0; // expected-error {{invalid operands to binary expression}}
local_int8 ^ 0; // expected-error {{invalid operands to binary expression}}
local_int8 << 0; // expected-error {{invalid operands to binary expression}}
local_int8 >> 0; // expected-error {{invalid operands to binary expression}}
local_int8 < 0; // expected-error {{invalid operands to binary expression}}
local_int8 <= 0; // expected-error {{invalid operands to binary expression}}
local_int8 == 0; // expected-error {{invalid operands to binary expression}}
local_int8 != 0; // expected-error {{invalid operands to binary expression}}
local_int8 >= 0; // expected-error {{invalid operands to binary expression}}
local_int8 > 0; // expected-error {{invalid operands to binary expression}}
local_int8 && 0; // expected-error {{invalid operands to binary expression}}
local_int8 || 0; // expected-error {{invalid operands to binary expression}}

if (local_int8) { // expected-error {{statement requires expression of scalar type}}
}
while (local_int8) { // expected-error {{statement requires expression of scalar type}}
}
do { // expected-error {{statement requires expression of scalar type}}
} while (local_int8);
switch (local_int8) { // expected-error {{statement requires expression of integer type}}
default:;
}
}

int vararg_receiver(int count, svint8_t first, ...) {
__builtin_va_list va;

__builtin_va_start(va, first);
__builtin_va_arg(va, svint8_t);
__builtin_va_end(va);
return count;
}

#if __STDC_VERSION__ >= 201112L
void test_generic(void) {
svint8_t local_int8;
svint16_t local_int16;

int a1[_Generic(local_int8, svint8_t : 1, svint16_t : 2, default : 3) == 1 ? 1 : -1];
int a2[_Generic(local_int16, svint8_t : 1, svint16_t : 2, default : 3) == 2 ? 1 : -1];
int a3[_Generic(0, svint8_t : 1, svint16_t : 2, default : 3) == 3 ? 1 : -1];
(void)_Generic(0, svint8_t : 1, svint8_t : 2, default : 3); // expected-error {{type 'svint8_t' (aka '__SVInt8_t') in generic association compatible with previously specified type 'svint8_t'}} expected-note {{compatible type}}
}
#endif

0 comments on commit f09c7d6

Please sign in to comment.