[clang][Sema][NFC] Clean up BuildOverloadedCallExpr

llvm · Jan 8, 2024 · f0f16be · f0f16be
1 parent 4a45648
commit f0f16be
Showing 1 changed file with 6 additions and 9 deletions.
diff --git a/clang/lib/Sema/SemaOverload.cpp b/clang/lib/Sema/SemaOverload.cpp
@@ -13999,17 +13999,14 @@ ExprResult Sema::BuildOverloadedCallExpr(Scope *S, Expr *Fn,
   // encloses the call and whose return type contains a placeholder type as if
   // the UnresolvedLookupExpr was type-dependent.
   if (OverloadResult == OR_Success) {
-    FunctionDecl *FDecl = Best->Function;
+    const FunctionDecl *FDecl = Best->Function;
     if (FDecl && FDecl->isTemplateInstantiation() &&
         FDecl->getReturnType()->isUndeducedType()) {
-      if (auto TP = FDecl->getTemplateInstantiationPattern(false)) {
-        if (TP->willHaveBody()) {
-          CallExpr *CE =
-              CallExpr::Create(Context, Fn, Args, Context.DependentTy,
-                               VK_PRValue, RParenLoc, CurFPFeatureOverrides());
-          result = CE;
-          return result;
-        }
+      if (const auto *TP =
+              FDecl->getTemplateInstantiationPattern(/*ForDefinition=*/false);
+          TP && TP->willHaveBody()) {
+        return CallExpr::Create(Context, Fn, Args, Context.DependentTy,
+                                VK_PRValue, RParenLoc, CurFPFeatureOverrides());
       }
     }
   }