Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[clangd] Skip (most) predefined macros when scanning for preamble pat…
…ching. This is unneccesary work. With this change, we skip generating and lexing ~10k of predefines twice. A dumb benchmark of building a preamble for an empty file in a loop shows: - before: 1.90ms/run - after: 1.36ms/run So this should be worth 0.5ms for each AST build and code completion. There can be a functional difference, but it's very minor. If the preamble contains e.g. `#ifndef __llvm__ ... #endif` then before we would not take it. After this change we will take the branch (single-file mode takes all branches with unknown conditions) and so gather different directives. However I think this is negligible: - this is already true of non-builtin macros (from included headers). We've had no complaints. - this affects the baseline and modified in the same way, so only makes a difference transiently when code guarded by such an #ifdef is being edited Differential Revision: https://reviews.llvm.org/D125179
- Loading branch information