Skip to content

Commit

Permalink
[mips][test] Remove redundant and invalid CHECK-NOT directives. NFC
Browse files Browse the repository at this point in the history
1. It's redundant to explicitly check that string does not contain `PAUSE_MM`
   token if check that the `PAUSE` token is followed by an angle bracket.
2. The removed `CHECK-NOT` directives do not have trailing colons.
  • Loading branch information
atanasyan committed Apr 3, 2020
1 parent 9068bcc commit f22445b
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 16 deletions.
3 changes: 1 addition & 2 deletions llvm/test/MC/Mips/mips32r2/valid.s
Expand Up @@ -209,8 +209,7 @@ a:
or $12,$s0,$sp
or $2, 4 # CHECK: ori $2, $2, 4 # encoding: [0x34,0x42,0x00,0x04]
pause # CHECK: pause # encoding: [0x00,0x00,0x01,0x40]
# CHECK-NEXT: # <MCInst #{{[0-9]+}} PAUSE
# CHECK-NOT # <MCInst #{{[0-9}+}} PAUSE_MM
# CHECK-NEXT: # <MCInst #{{[0-9]+}} PAUSE>
pref 1, 8($5) # CHECK: pref 1, 8($5) # encoding: [0xcc,0xa1,0x00,0x08]
# FIXME: Use the code generator in order to print the .set directives
# instead of the instruction printer.
Expand Down
3 changes: 1 addition & 2 deletions llvm/test/MC/Mips/mips32r3/valid.s
Expand Up @@ -209,8 +209,7 @@ a:
or $12,$s0,$sp
or $2, 4 # CHECK: ori $2, $2, 4 # encoding: [0x34,0x42,0x00,0x04]
pause # CHECK: pause # encoding: [0x00,0x00,0x01,0x40]
# CHECK-NEXT: # <MCInst #{{[0-9]+}} PAUSE
# CHECK-NOT # <MCInst #{{[0-9}+}} PAUSE_MM
# CHECK-NEXT: # <MCInst #{{[0-9]+}} PAUSE>
pref 1, 8($5) # CHECK: pref 1, 8($5) # encoding: [0xcc,0xa1,0x00,0x08]
# FIXME: Use the code generator in order to print the .set directives
# instead of the instruction printer.
Expand Down
3 changes: 1 addition & 2 deletions llvm/test/MC/Mips/mips32r5/valid.s
Expand Up @@ -210,8 +210,7 @@ a:
or $12,$s0,$sp
or $2, 4 # CHECK: ori $2, $2, 4 # encoding: [0x34,0x42,0x00,0x04]
pause # CHECK: pause # encoding: [0x00,0x00,0x01,0x40]
# CHECK-NEXT: # <MCInst #{{[0-9]+}} PAUSE
# CHECK-NOT # <MCInst #{{[0-9}+}} PAUSE_MM
# CHECK-NEXT: # <MCInst #{{[0-9]+}} PAUSE>
pref 1, 8($5) # CHECK: pref 1, 8($5) # encoding: [0xcc,0xa1,0x00,0x08]
# FIXME: Use the code generator in order to print the .set directives
# instead of the instruction printer.
Expand Down
3 changes: 1 addition & 2 deletions llvm/test/MC/Mips/mips32r6/valid.s
Expand Up @@ -149,8 +149,7 @@ a:
not $3, $4 # CHECK: not $3, $4 # encoding: [0x00,0x80,0x18,0x27]
not $3 # CHECK: not $3, $3 # encoding: [0x00,0x60,0x18,0x27]
pause # CHECK: pause # encoding: [0x00,0x00,0x01,0x40]
# CHECK-NEXT: # <MCInst #{{[0-9]+}} PAUSE
# CHECK-NOT # <MCInst #{{[0-9}+}} PAUSE_MM
# CHECK-NEXT: # <MCInst #{{[0-9]+}} PAUSE>
pref 1, 8($5) # CHECK: pref 1, 8($5) # encoding: [0x7c,0xa1,0x04,0x35]
# CHECK-NEXT: # <MCInst #{{.*}} PREF_R6
# FIXME: Use the code generator in order to print the .set directives
Expand Down
3 changes: 1 addition & 2 deletions llvm/test/MC/Mips/mips64r2/valid.s
Expand Up @@ -287,8 +287,7 @@ a:
or $12,$s0,$sp
or $2, 4 # CHECK: ori $2, $2, 4 # encoding: [0x34,0x42,0x00,0x04]
pause # CHECK: pause # encoding: [0x00,0x00,0x01,0x40]
# CHECK-NEXT: # <MCInst #{{[0-9]+}} PAUSE
# CHECK-NOT # <MCInst #{{[0-9}+}} PAUSE_MM
# CHECK-NEXT: # <MCInst #{{[0-9]+}} PAUSE>
pll.ps $f26,$f10,$f30 # CHECK: pll.ps $f26, $f10, $f30 # encoding: [0x46,0xde,0x56,0xac]
# CHECK: # <MCInst #{{[0-9]+}} PLL_PS64
plu.ps $f2,$f26,$f30 # CHECK: plu.ps $f2, $f26, $f30 # encoding: [0x46,0xde,0xd0,0xad]
Expand Down
3 changes: 1 addition & 2 deletions llvm/test/MC/Mips/mips64r3/valid.s
Expand Up @@ -281,8 +281,7 @@ a:
or $12,$s0,$sp
or $2, 4 # CHECK: ori $2, $2, 4 # encoding: [0x34,0x42,0x00,0x04]
pause # CHECK: pause # encoding: [0x00,0x00,0x01,0x40]
# CHECK-NEXT: # <MCInst #{{[0-9]+}} PAUSE
# CHECK-NOT # <MCInst #{{[0-9}+}} PAUSE_MM
# CHECK-NEXT: # <MCInst #{{[0-9]+}} PAUSE>
pll.ps $f26,$f10,$f30 # CHECK: pll.ps $f26, $f10, $f30 # encoding: [0x46,0xde,0x56,0xac]
# CHECK: # <MCInst #{{[0-9]+}} PLL_PS64
plu.ps $f2,$f26,$f30 # CHECK: plu.ps $f2, $f26, $f30 # encoding: [0x46,0xde,0xd0,0xad]
Expand Down
3 changes: 1 addition & 2 deletions llvm/test/MC/Mips/mips64r5/valid.s
Expand Up @@ -283,8 +283,7 @@ a:
or $12,$s0,$sp
or $2, 4 # CHECK: ori $2, $2, 4 # encoding: [0x34,0x42,0x00,0x04]
pause # CHECK: pause # encoding: [0x00,0x00,0x01,0x40]
# CHECK-NEXT: # <MCInst #{{[0-9]+}} PAUSE
# CHECK-NOT # <MCInst #{{[0-9}+}} PAUSE_MM
# CHECK-NEXT: # <MCInst #{{[0-9]+}} PAUSE>
pll.ps $f26,$f10,$f30 # CHECK: pll.ps $f26, $f10, $f30 # encoding: [0x46,0xde,0x56,0xac]
# CHECK: # <MCInst #{{[0-9]+}} PLL_PS64
plu.ps $f2,$f26,$f30 # CHECK: plu.ps $f2, $f26, $f30 # encoding: [0x46,0xde,0xd0,0xad]
Expand Down
3 changes: 1 addition & 2 deletions llvm/test/MC/Mips/mips64r6/valid.s
Expand Up @@ -213,8 +213,7 @@ a:
not $3 # CHECK: not $3, $3 # encoding: [0x00,0x60,0x18,0x27]
or $2, 4 # CHECK: ori $2, $2, 4 # encoding: [0x34,0x42,0x00,0x04]
pause # CHECK: pause # encoding: [0x00,0x00,0x01,0x40]
# CHECK-NEXT: # <MCInst #{{[0-9]+}} PAUSE
# CHECK-NOT # <MCInst #{{[0-9}+}} PAUSE_MM
# CHECK-NEXT: # <MCInst #{{[0-9]+}} PAUSE>
pref 1, 8($5) # CHECK: pref 1, 8($5) # encoding: [0x7c,0xa1,0x04,0x35]
# FIXME: Use the code generator in order to print the .set directives
# instead of the instruction printer.
Expand Down

0 comments on commit f22445b

Please sign in to comment.