[LoongArch] Fix undefined behavior: left shift of negative value

Fix undefined behavior in `decodeSImmOperand` where we were left shifting a signed value.
llvm · Jan 11, 2023 · f292d53 · f292d53
1 parent ae6a5c1
commit f292d53
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/llvm/lib/Target/LoongArch/Disassembler/LoongArchDisassembler.cpp b/llvm/lib/Target/LoongArch/Disassembler/LoongArchDisassembler.cpp
@@ -114,9 +114,9 @@ static DecodeStatus decodeSImmOperand(MCInst &Inst, uint64_t Imm,
                                       int64_t Address,
                                       const MCDisassembler *Decoder) {
   assert(isUInt<N>(Imm) && "Invalid immediate");
-  // Sign-extend the number in the bottom <N> bits of Imm, then shift left <S>
+  // Shift left Imm <S> bits, then sign-extend the number in the bottom <N+S>
   // bits.
-  Inst.addOperand(MCOperand::createImm(SignExtend64<N>(Imm) << S));
+  Inst.addOperand(MCOperand::createImm(SignExtend64<N + S>(Imm << S)));
   return MCDisassembler::Success;
 }