-
Notifications
You must be signed in to change notification settings - Fork 11k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reland: "[libc] Templatize str{,n}cmp"
This will be used to implement the case insensitive str{,n}casecmp This was initially reverted because it broke tests on arm platforms. Unfortunately, it didn't break on my arm machine, but I suspect the problem was the old comparator returned char and not int. Differential Revision: https://reviews.llvm.org/D141235
- Loading branch information
Showing
6 changed files
with
63 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
//===-- str{,case}cmp implementation ----------------------------*- C++ -*-===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#ifndef LLVM_LIBC_SRC_STRING_MEMORY_UTILS_STRCMP_IMPLEMENTATIONS_H | ||
#define LLVM_LIBC_SRC_STRING_MEMORY_UTILS_STRCMP_IMPLEMENTATIONS_H | ||
|
||
#include <stddef.h> | ||
|
||
namespace __llvm_libc { | ||
|
||
template <typename Comp> | ||
constexpr static int strcmp_implementation(const char *left, const char *right, | ||
Comp &&comp) { | ||
// TODO: Look at benefits for comparing words at a time. | ||
for (; *left && !comp(*left, *right); ++left, ++right) | ||
; | ||
return comp(*reinterpret_cast<const unsigned char *>(left), | ||
*reinterpret_cast<const unsigned char *>(right)); | ||
} | ||
|
||
template <typename Comp> | ||
constexpr static int strncmp_implementation(const char *left, const char *right, | ||
size_t n, Comp &&comp) { | ||
if (n == 0) | ||
return 0; | ||
|
||
// TODO: Look at benefits for comparing words at a time. | ||
for (; n > 1; --n, ++left, ++right) { | ||
char lc = *left; | ||
if (!comp(lc, '\0') || comp(lc, *right)) | ||
break; | ||
} | ||
return comp(*reinterpret_cast<const unsigned char *>(left), | ||
*reinterpret_cast<const unsigned char *>(right)); | ||
} | ||
|
||
} // namespace __llvm_libc | ||
|
||
#endif // LLVM_LIBC_SRC_STRING_MEMORY_UTILS_STRCMP_IMPLEMENTATIONS_H |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters