Skip to content

Commit

Permalink
Merging r262230:
Browse files Browse the repository at this point in the history
------------------------------------------------------------------------
r262230 | vkalintiris | 2016-02-29 15:58:12 +0000 (Mon, 29 Feb 2016) | 7 lines

[mips] Do not use SLL for ANY_EXTEND nodes as the high bits are undefined.

Reviewers: dsanders

Subscribers: dsanders, llvm-commits

Differential Revision: http://reviews.llvm.org/D15420
------------------------------------------------------------------------

llvm-svn: 271126
  • Loading branch information
dsandersllvm committed May 28, 2016
1 parent 06b9607 commit f32e5c1
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 20 deletions.
3 changes: 2 additions & 1 deletion llvm/lib/Target/Mips/Mips64InstrInfo.td
Expand Up @@ -518,7 +518,8 @@ def : MipsPat<(rotr GPR64:$rt, (i32 (trunc GPR64:$rs))),
(DROTRV GPR64:$rt, (EXTRACT_SUBREG GPR64:$rs, sub_32))>;

// 32-to-64-bit extension
def : MipsPat<(i64 (anyext GPR32:$src)), (SLL64_32 GPR32:$src)>;
def : MipsPat<(i64 (anyext GPR32:$src)),
(INSERT_SUBREG (i64 (IMPLICIT_DEF)), GPR32:$src, sub_32)>;
def : MipsPat<(i64 (zext GPR32:$src)), (DSRL (DSLL64_32 GPR32:$src), 32)>;
def : MipsPat<(i64 (sext GPR32:$src)), (SLL64_32 GPR32:$src)>;

Expand Down
3 changes: 0 additions & 3 deletions llvm/test/CodeGen/Mips/cconv/return-struct.ll
Expand Up @@ -158,9 +158,6 @@ entry:
; sret pointer is already in $4
; N32-DAG: lui [[PTR_HI:\$[0-9]+]], %hi(struct_128xi16)
; N32-DAG: addiu [[PTR:\$[0-9]+]], [[PTR_HI]], %lo(struct_128xi16)
; FIXME: This signext isn't necessary. Like integers, pointers are
; but unlike integers, pointers cannot have the signext attribute.
; N32-DAG: sll $5, [[PTR]], 0
; N32: jal memcpy

; sret pointer is already in $4
Expand Down
36 changes: 20 additions & 16 deletions llvm/test/CodeGen/Mips/fcopysign-f32-f64.ll
@@ -1,14 +1,18 @@
; RUN: llc < %s -march=mips64el -mcpu=mips4 -target-abi=n64 | FileCheck %s -check-prefix=64
; RUN: llc < %s -march=mips64el -mcpu=mips64 -target-abi=n64 | FileCheck %s -check-prefix=64
; RUN: llc < %s -march=mips64el -mcpu=mips64r2 -target-abi=n64 | FileCheck %s -check-prefix=64R2
; RUN: llc < %s -march=mips64el -mcpu=mips4 -target-abi=n64 | \
; RUN: FileCheck %s -check-prefix=ALL -check-prefix=64
; RUN: llc < %s -march=mips64el -mcpu=mips64 -target-abi=n64 | \
; RUN: FileCheck %s -check-prefix=ALL -check-prefix=64
; RUN: llc < %s -march=mips64el -mcpu=mips64r2 -target-abi=n64 | \
; RUN: FileCheck %s -check-prefix=ALL -check-prefix=64R2

declare double @copysign(double, double) nounwind readnone

declare float @copysignf(float, float) nounwind readnone

define float @func2(float %d, double %f) nounwind readnone {
entry:
; 64: func2
; ALL-LABEL: func2:

; 64-DAG: lui $[[T0:[0-9]+]], 32767
; 64-DAG: ori $[[MSK0:[0-9]+]], $[[T0]], 65535
; 64-DAG: and $[[AND0:[0-9]+]], ${{[0-9]+}}, $[[MSK0]]
Expand All @@ -30,17 +34,18 @@ entry:

define double @func3(double %d, float %f) nounwind readnone {
entry:

; 64: func3
; 64-DAG: daddiu $[[T0:[0-9]+]], $zero, 1
; 64-DAG: dsll $[[T1:[0-9]+]], $[[T0]], 63
; 64-DAG: daddiu $[[MSK0:[0-9]+]], $[[T1]], -1
; 64-DAG: and $[[AND0:[0-9]+]], ${{[0-9]+}}, $[[MSK0]]
; 64-DAG: srl $[[SRL:[0-9]+]], ${{[0-9]+}}, 31
; 64-DAG: sll $[[SLL:[0-9]+]], $[[SRL]], 0
; 64-DAG: dsll $[[DSLL:[0-9]+]], $[[SLL]], 63
; 64: or $[[OR:[0-9]+]], $[[AND0]], $[[DSLL]]
; 64: dmtc1 $[[OR]], $f0
; ALL-LABEL: func3:

; 64-DAG: mfc1 $[[MFC:[0-9]+]], $f13
; 64-DAG: srl $[[SRL:[0-9]+]], $[[MFC:[0-9]+]], 31
; 64: dsll $[[DSLL:[0-9]+]], $[[SRL]], 63
; 64-DAG: daddiu $[[R1:[0-9]+]], $zero, 1
; 64-DAG: dsll $[[R2:[0-9]+]], $[[R1]], 63
; 64-DAG: daddiu $[[R3:[0-9]+]], $[[R2]], -1
; 64-DAG: dmfc1 $[[R0:[0-9]+]], ${{.*}}
; 64: and $[[AND0:[0-9]+]], $[[R0]], $[[R3]]
; 64: or $[[OR:[0-9]+]], $[[AND0]], $[[DSLL]]
; 64: dmtc1 $[[OR]], $f0

; 64R2: ext ${{[0-9]+}}, ${{[0-9]+}}, 31, 1
; 64R2: dins $[[INS:[0-9]+]], ${{[0-9]+}}, 63, 1
Expand All @@ -51,4 +56,3 @@ entry:
%call = tail call double @copysign(double %add, double %conv) nounwind readnone
ret double %call
}

0 comments on commit f32e5c1

Please sign in to comment.